Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow azurerm_function_app to use upper case names in consumption plan #1835

Merged
merged 3 commits into from
Aug 30, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Aug 28, 2018

This fixes BUG #1765 , which will only happen on functions app with consumption plan using "Dynamic" "Y1" sku. The root cause is that content share name is not allowed to use upper case letters.

New API request: Azure/azure-rest-api-specs#3750.

@ghost ghost added the size/M label Aug 28, 2018
@JunyiYi JunyiYi self-assigned this Aug 28, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing but this otherwise LGTM 👍

azurerm/resource_arm_function_app.go Show resolved Hide resolved
@ghost ghost added the size/M label Aug 28, 2018
@tombuildsstuff tombuildsstuff added this to the 1.14.0 milestone Aug 29, 2018
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-08-30 at 12 01 29

@tombuildsstuff tombuildsstuff merged commit 3fb0d8f into master Aug 30, 2018
@tombuildsstuff tombuildsstuff deleted the fix_funcapp_upcasename branch August 30, 2018 11:01
tombuildsstuff added a commit that referenced this pull request Aug 30, 2018
torresdal pushed a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 31, 2018
hashicorp#1835)

* Add repro test case for hashicorp#1765

* Lower-case the content share name to prevent Bad Request

* Add link to the API request as TODO item.
torresdal pushed a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 31, 2018
jbcom pushed a commit to platonic-io/terraform-provider-azurerm that referenced this pull request Sep 27, 2018
* timcurless/timcurless:
  Fixing issues with aadProfile server_app_secret always causing a new cluster
  Adding documentation updates
  Updating to include hashicorp#1845
  Authentication: registering all clients consistently (hashicorp#1845)
  Updating to include hashicorp#1843
  r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843)
  Updating to include hashicorp#1821
  linux_profile should be optional to align with API spec (hashicorp#1821)
  Updating to include hashicorp#1816
  Storage: Import Support (hashicorp#1816)
  Updating to include hashicorp#1835
  Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835)
  formatting
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants