r/Logic App: ensuring parameters are strings prior to setting #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tombuildsstuff
requested review from
bflad and
a team
and removed request for
bflad
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Aug 30, 2018
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
jbcom
pushed a commit
to platonic-io/terraform-provider-azurerm
that referenced
this pull request
Sep 27, 2018
* timcurless/timcurless: Fixing issues with aadProfile server_app_secret always causing a new cluster Adding documentation updates Updating to include hashicorp#1845 Authentication: registering all clients consistently (hashicorp#1845) Updating to include hashicorp#1843 r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843) Updating to include hashicorp#1821 linux_profile should be optional to align with API spec (hashicorp#1821) Updating to include hashicorp#1816 Storage: Import Support (hashicorp#1816) Updating to include hashicorp#1835 Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835) formatting
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time the Logic App resource only supports setting String parameters - as such we should only set fields of this type.
Unfortunately adding an acceptance test for this is complicated (insofar as it requires a template which supports parameters of different types, which we don't support at this time) - but I can confirm via the portal this fix solves the crash #1841 [as it crashes on v1.13.0, but imports fine via this branch])
Fixes #1841