Storage: Import Support #1816
Merged
Storage: Import Support #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ acctests azurerm TestAccAzureRMStorageTable_basic === RUN TestAccAzureRMStorageTable_basic --- PASS: TestAccAzureRMStorageTable_basic (89.22s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 89.596s ```
mbfrahry
approved these changes
Aug 24, 2018
| segments := strings.Split(uri.Host, ".") | ||
| if len(segments) > 0 { | ||
| storageAccountName := segments[0] | ||
| // remove the |
There was a problem hiding this comment.
Is this an unfinished comment?
There was a problem hiding this comment.
Yep - good spot, ta
| segments := strings.Split(uri.Host, ".") | ||
| if len(segments) > 0 { | ||
| storageAccountName := segments[0] | ||
| // remove the |
There was a problem hiding this comment.
Yep - good spot, ta
- Ensuring all the fields are set for the Blob and Container resources - Removing the separate Exists functions
tombuildsstuff
force-pushed
the
storage-import
branch
from
ec59a6b
to
8ae12fc
Compare
|
Ignoring a couple of expected test failures (to do with a change within Azure where encrypted storage accounts are now mandatory) - the tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Aug 30, 2018
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
* Storage Blob: updating the ID to allow importing * Storage Blob: Import support * Storage Container: updating the ID * Storage Container: support for import * Including `blob` in the uri * Storage Queue: fixing the id / supporting import * Storage Table: fixing the ID / import support ``` $ acctests azurerm TestAccAzureRMStorageTable_basic === RUN TestAccAzureRMStorageTable_basic --- PASS: TestAccAzureRMStorageTable_basic (89.22s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 89.596s ``` * Removing an unused comment * Setting the fields for the Blob/Container resources - Ensuring all the fields are set for the Blob and Container resources - Removing the separate Exists functions
torresdal
pushed a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 31, 2018
jbcom
pushed a commit
to platonic-io/terraform-provider-azurerm
that referenced
this pull request
Sep 27, 2018
* timcurless/timcurless: Fixing issues with aadProfile server_app_secret always causing a new cluster Adding documentation updates Updating to include hashicorp#1845 Authentication: registering all clients consistently (hashicorp#1845) Updating to include hashicorp#1843 r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843) Updating to include hashicorp#1821 linux_profile should be optional to align with API spec (hashicorp#1821) Updating to include hashicorp#1816 Storage: Import Support (hashicorp#1816) Updating to include hashicorp#1835 Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835) formatting
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a dependency for #1746 - and adds support for Import to the Storage Resources. In order to do this the ID's need changing to contain all of the necessary information - which requires a state migration, and will require appropriate changelog comments.
azurerm_storage_blobazurerm_storage_containerazurerm_storage_queueazurerm_storage_tableFixes #1302
Fixes #1554
Fixes #1830