-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Meta Ticket #84
Comments
Thanks for writing that up, @armon. I'll take a shot at "Change inflight tracking". |
…. fixes Issue hashicorp#84 item 1
…. fixes Issue hashicorp#84 item 1
I'll start on 'precommit may not be necessary with new inflight' (though I only have about 20min right now, ugh). |
Ok I'm going to go ahead and merge #117. Here's the list of remaining tasks I identified from that. Most of these are already marked inline with TODO comments:
|
Cool, thanks @slackpad. I've got a busy day tomorrow but can help out later in the week. |
Cool I will keep adding the unit test work to the same PR in that case.
|
Ok I think #127 is in good shape for merge. Tomorrow I'm going to spend some time on these two items:
Will experiment a little and write up a spec so we can figure out the right way forward with these. We will need a way for Consul to take the existing peers.json and call some new Raft APIs in order to start up the cluster as well, since the peers.json had the only state related to the peers if a snapshot had been taken. I don't think I want to reintroduce the peer store into Raft, but Consul will need to parse this file outside of Raft and call some bootstrap-y thing to get going. I think this problem is closely related to the items above. |
@slackpad, small request: could you number the post-117 checklist above? It'd help me track things. |
@ongardie numbered the todo list |
BTW I'm trying to refactor a ton of stuff that'll help or fix the following:
so save those for me for now :) |
@ongardie thanks for the heads up. I'm working on 1, 2, 3 which should not conflict with your stuff too much. Should have a PR up soon so you can see what I'm thinking wrt. to these. Have a good weekend! |
@slackpad, now that I know you don't have too much outstanding, can we move |
Yep - I was starting to think about that, too. I'll go ahead and make that change and commit it now so we have a good basis for further work. |
Thanks @slackpad! |
Some bookkeeping:
I think that's all I'm sitting on. |
@ongardie-sfdc thanks for the update and the detailed reviews! I reconciled all your changes with the checklists (added new numbered items for the two new ones). |
After merging the version and recovery stuff into issue-84-integration, I cut https://github.com/hashicorp/raft/tree/library-v2-stage-one. I'll integrate and ship the next version of Consul against this branch and keep it open for small fixes I can pick from here if needed. This'll free up the issue-84-integration branch for the goroutine changes and a possible period of instability as that settles in. After giving the community a heads up wrt. the interface changes we can take issue-84-integration into master, and possibly make library-v2-stage-two as an interim bake and integrate target for future Consul versions. |
Hi @superfell - there's a test here that hits it - https://github.com/hashicorp/raft/blob/issue-84-integration/raft_test.go#L2217-L2258. It's likely that you are calling |
Also, if you don't need to support any of the old stuff, I'd keep the |
Ahh, the setting of protocolVer in DefaultConfig() was messing with me. |
Everything is done or tracked elsewhere - closing! |
Here are the list of issues, grouped together if they might make sense as a single PR.
State Races
Multi-Row Fetching
Replace single row lookups with multi row lookups (LogStore / LogCache) (look at cases around log truncation)Follower Replication:
replicateTo
should verify leadership is current during loopingstopCh
Change Inflight Tracking
precommit
may not be necessary with new inflight (likely will be cleaned up via Discussion: reworking membership changes #117)Improve Membership Tracking
Crashes / Restart Issues
Panic with old snapshots Panic getting logs after restoring from an older snapshot #85TrailingLogs set to 0 with restart bug Behaviour on setting TrailingLogs to 0 #86New Tests
/cc: @superfell @ongardie @sean- @ryanuber @slackpad
The text was updated successfully, but these errors were encountered: