-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the stats into a real structure #167
Comments
Another thing I wanted to do was to get at the term from my application (to ensure it hadn't changed across a period of time for reasons I can explain in gory detail). Should that be a new getTerm() or should this cover it? |
I think you'd get the term in this stats struct. |
I think we should make getting this stats struct a proper query into the main raft.go goroutine over a channel. This would help a lot with #172 (merging state.go into raft.go). |
Yeah a future, similar to what we did for the configuration getter would be good for this as well. |
btw I'm starting on this one. |
Towards hashicorp#167: Make the stats into a real structure
For hashicorp#167: Make the stats into a real structure
Towards hashicorp#167: Make the stats into a real structure
For hashicorp#167: Make the stats into a real structure
Towards hashicorp#167: Make the stats into a real structure
For hashicorp#167: Make the stats into a real structure
@ongardie-sfdc this one can be closed I think, right? |
@slackpad oh, I thought so but now I see the comment:
Better check on that before we close it out. |
Close hashicorp#167: Make the stats into a real structure
PR #191 finishes this up. |
Clean up how configuration comes out in
Stats()
, the"%+v"
formatting is weird / ugly. Also add a test to make sure it shows up (fixed a bug where the logic was wrong).Better yet, make a new stats API that pulls the structure in one go w/o text.
The text was updated successfully, but these errors were encountered: