Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the stats into a real structure #167

Closed
slackpad opened this issue Oct 7, 2016 · 8 comments
Closed

Make the stats into a real structure #167

slackpad opened this issue Oct 7, 2016 · 8 comments
Milestone

Comments

@slackpad
Copy link
Contributor

slackpad commented Oct 7, 2016

Clean up how configuration comes out in Stats(), the "%+v" formatting is weird / ugly. Also add a test to make sure it shows up (fixed a bug where the logic was wrong).

Better yet, make a new stats API that pulls the structure in one go w/o text.

@slackpad slackpad added this to the v2 milestone Oct 7, 2016
@slackpad slackpad mentioned this issue Oct 7, 2016
14 tasks
@ongardie
Copy link
Contributor

ongardie commented Oct 7, 2016

Another thing I wanted to do was to get at the term from my application (to ensure it hadn't changed across a period of time for reasons I can explain in gory detail). Should that be a new getTerm() or should this cover it?

@slackpad
Copy link
Contributor Author

slackpad commented Oct 7, 2016

I think you'd get the term in this stats struct.

@ongardie-sfdc
Copy link

I think we should make getting this stats struct a proper query into the main raft.go goroutine over a channel. This would help a lot with #172 (merging state.go into raft.go).

@slackpad
Copy link
Contributor Author

slackpad commented Oct 7, 2016

Yeah a future, similar to what we did for the configuration getter would be good for this as well.

@ongardie-sfdc
Copy link

btw I'm starting on this one.

ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 14, 2016
Towards hashicorp#167: Make the stats into a real structure
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 14, 2016
For hashicorp#167: Make the stats into a real structure
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 17, 2016
Towards hashicorp#167: Make the stats into a real structure
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 17, 2016
For hashicorp#167: Make the stats into a real structure
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 18, 2016
Towards hashicorp#167: Make the stats into a real structure
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 18, 2016
For hashicorp#167: Make the stats into a real structure
@slackpad
Copy link
Contributor Author

@ongardie-sfdc this one can be closed I think, right?

@ongardie
Copy link
Contributor

@slackpad oh, I thought so but now I see the comment:

Clean up how configuration comes out in Stats(), the "%+v" formatting is weird / ugly. Also add a test to make sure it shows up (fixed a bug where the logic was wrong).

Better check on that before we close it out.

ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 31, 2016
Close hashicorp#167: Make the stats into a real structure
@ongardie-sfdc
Copy link

PR #191 finishes this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants