Bug fixes + issue 167 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were showing up as defaultLogger.go before. It should be a bit more robust now, though slower.
This was effectively granting even nonvoting servers a 0 vote if their terms were out of date, which could delay commitment decisions.
Close hashicorp#167: Make the stats into a real structure
slackpad
reviewed
Oct 31, 2016
| file := "???" | ||
| line := 0 | ||
| depth := 0 | ||
| for { |
There was a problem hiding this comment.
I thought about doing this and hoped we didn't have to, but didn't catch the Error() case. Should be fine for tests, I agree.
|
This String() function broke the unit tests, working on fixing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.