Split apart and test appendConfigurationEntry #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where AddNonvoter would previously demote a server from Staging to Nonvoter (the intended semantics are no-op in that case). This is hashicorp#14 on James's post-PR-117 checklist.
| // it'll instruct the replication routines to try to replicate to the current | ||
| // index. | ||
| func (r *Raft) startStopReplication() { | ||
| inConfig := make(map[ServerID]bool, len(r.leaderState.replState)) |
There was a problem hiding this comment.
This should probably be len(r.configurations.latest.Servers). This'll be 0 at this time.
There was a problem hiding this comment.
Nevermind - not for the stop case.
There was a problem hiding this comment.
Even then, you're still right: there'll be one entry in the map per len(r.configurations.latest.Servers), perhaps except for the local server.
There was a problem hiding this comment.
Yeah it can't hurt to use that as the size for sure.
|
@ongardie just a few minor comments, otherwise LGTM! |
This simplifies the signature for nextConfiguration. In response to comments on PR#132.
|
Pushed a few more, I think that addressed all the comments. |
|
Looks good - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where AddNonvoter would previously demote a server from
Staging to Nonvoter (the intended semantics are no-op in that case).
This is box 14 on James's post- #117 checklist on #84.