Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update gopsutil to v2.19.6 #7347

Closed
wants to merge 3 commits into from

Conversation

greut
Copy link
Contributor

@greut greut commented Mar 14, 2020

The Stolen field has been removed, shirou/gopsutil#677 as it wasn't used. This pull request upgrade that dependency and corrects the code accordingly.

gopsutil 2.19.7 introduce breaking changes with the vendored version of docker; pretty please update docker.

Closes #6483, #6957

@greut greut changed the title vendor: update gopsutil to v2.20.2 vendor: update gopsutil to v2.19.6 Mar 14, 2020
@greut greut force-pushed the gopsutil-v2.20.2 branch from 0c89a62 to 8a3b0a2 Compare March 14, 2020 09:39
@notnoop
Copy link
Contributor

notnoop commented Mar 14, 2020

Thank you so much for your contribution. I'm afraid upgrading gopsutil is a bit more complicated.

2.18.12 introduced a backward compatible change to windows cpu handling in shirou/gopsutil@eead265 .

We aim to upgrade docker and gopsutil to the latest, at least so we can pick up a panic fix in 2.20.1 shirou/gopsutil@3964e5b .

We'd appreciate any PR that upgrades docker/gopsutil to the latest, though I'm also aiming to get the packages upgraded for 0.11.

@greut
Copy link
Contributor Author

greut commented Mar 14, 2020

@notnoop I see, this issue is way harder that I thought. Should I try again that one? #5807

@notnoop
Copy link
Contributor

notnoop commented Mar 14, 2020

That'd be wonderful indeed. fwiw, I had a WIP branch in https://github.com/hashicorp/nomad/commits/b-update-gopsutil-20200127 but I haven't gotten it across the line. Two commits are fixes to changes in gopsutil and docker types, but I assume we need more govendor magic incantations to get this working :(.

@greut
Copy link
Contributor Author

greut commented Mar 14, 2020

@notnoop Great... IIRC I had to battle quite a lot with govendor. I'm closing this then.

@greut greut closed this Mar 14, 2020
@greut greut deleted the gopsutil-v2.20.2 branch March 15, 2020 11:06
@tgross tgross mentioned this pull request Mar 16, 2020
@tgross tgross mentioned this pull request Mar 30, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update gopsutil
2 participants