-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update gopsutil to v2.19.6 #7347
Conversation
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Thank you so much for your contribution. I'm afraid upgrading gopsutil is a bit more complicated. 2.18.12 introduced a backward compatible change to windows cpu handling in shirou/gopsutil@eead265 . We aim to upgrade docker and gopsutil to the latest, at least so we can pick up a panic fix in 2.20.1 shirou/gopsutil@3964e5b . We'd appreciate any PR that upgrades docker/gopsutil to the latest, though I'm also aiming to get the packages upgraded for 0.11. |
That'd be wonderful indeed. fwiw, I had a WIP branch in https://github.com/hashicorp/nomad/commits/b-update-gopsutil-20200127 but I haven't gotten it across the line. Two commits are fixes to changes in gopsutil and docker types, but I assume we need more govendor magic incantations to get this working :(. |
@notnoop Great... IIRC I had to battle quite a lot with govendor. I'm closing this then. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The
Stolen
field has been removed, shirou/gopsutil#677 as it wasn't used. This pull request upgrade that dependency and corrects the code accordingly.gopsutil 2.19.7 introduce breaking changes with the vendored version of docker; pretty please update docker.
Closes #6483, #6957