-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gopsutil #6483
Comments
Note that shirou/gopsutil 2.19.05 introduced breaking change shirou/gopsutil@cae8efc as per shirou/gopsutil#676 that causes the following FTBFS in Nomad:
The patch for Nomad is trivial but please review it nevertheless:
|
Closed by #7347 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
The library we used for stats collection has changed how windows stats collection works:
shirou/gopsutil#611
This will affect this code:
https://github.com/hashicorp/nomad/blob/master/client/stats/cpu_windows.go#L12
This issue captures updating gopsutil, as well as testing windows specific changes.
The text was updated successfully, but these errors were encountered: