Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: docker v18.09.6 #5807

Closed
wants to merge 2 commits into from
Closed

vendor: docker v18.09.6 #5807

wants to merge 2 commits into from

Conversation

greut
Copy link
Contributor

@greut greut commented Jun 11, 2019 •
edited
Loading

  • bump docker/docker to v18.09.6 (from docker/engine), from version 2018-11-29
  • docker/go-connections v0.4.0
  • containerd/continuity pulled from master rather than docker's vendor
  • golang/x/net pulled from master rather than docker's vendor
  • fix govendor sync

@greut greut force-pushed the pin-docker-engine branch 2 times, most recently from b6dae2c to ca7fd62 Compare June 12, 2019 19:52
@greut greut closed this Jun 12, 2019
@greut greut deleted the pin-docker-engine branch June 12, 2019 21:29
@greut greut restored the pin-docker-engine branch June 12, 2019 21:30
@greut greut reopened this Jun 12, 2019
@greut
vendor: docker v18.09.6
9755053 
Signed-off-by: Yoan Blanc <[email protected]>
@greut greut force-pushed the pin-docker-engine branch from ca7fd62 to 9755053 Compare June 22, 2019 09:38
@greut
govendor sync fix
655a9b1 
Signed-off-by: Yoan Blanc <[email protected]>
@preetapan
Copy link
Contributor

@greut this is a pretty massive change in a core dependency and we do that quite carefully. Given the large surface area of this PR I am going to close this. We would accept a vendor upgrade PR if it gives specific reasons (for example any bug fixes or enabling new functionality)

@preetapan preetapan closed this Jul 15, 2019
@greut
Copy link
Contributor Author

greut commented Jul 15, 2019

@preetapan the current revision is from November 2018, what are you plans regarding the library dependencies update?

This was referenced Mar 14, 2020
Closed
Closed
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greut @preetapan