Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: script check testing #6252

Merged
merged 2 commits into from
Sep 6, 2019
Merged

e2e: script check testing #6252

merged 2 commits into from
Sep 6, 2019

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 3, 2019 •
edited
Loading

In support of #6197 and #6162

tgross
tgross commented Sep 3, 2019
View reviewed changes
e2e/consul/script_checks.go Outdated Show resolved Hide resolved
@tgross tgross force-pushed the f-e2e-script-checks branch 4 times, most recently from 64f062a to 272a252 Compare September 4, 2019 15:20
@tgross tgross mentioned this pull request Sep 4, 2019
Merged
@tgross tgross force-pushed the f-e2e-script-checks branch from 272a252 to a35c7ab Compare September 4, 2019 20:34
@tgross tgross marked this pull request as ready for review September 5, 2019 13:17
@tgross
Copy link
Member Author

tgross commented Sep 5, 2019

These are passing vs a local environment that includes #6265:

▶ go test -v ./e2e/ -run 'TestE2E/Consul/\*consul\.ScriptChecksE2ETest'
=== RUN   TestE2E
=== RUN   TestE2E/Consul
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest/TestGroupScriptCheck
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck
=== RUN   TestE2E/Consul_Template
--- PASS: TestE2E (65.71s)
    --- PASS: TestE2E/Consul (65.62s)
        --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest (65.45s)
            --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest/TestGroupScriptCheck (33.17s)
            --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck (32.15s)
    --- PASS: TestE2E/Consul_Template (0.09s)
PASS
ok      github.com/hashicorp/nomad/e2e  68.029s

@tgross tgross force-pushed the f-e2e-script-checks branch from a35c7ab to dd18f15 Compare September 5, 2019 13:20
@tgross tgross added this to the 0.10.0 milestone Sep 5, 2019
@tgross tgross force-pushed the f-e2e-script-checks branch from dd18f15 to 4326422 Compare September 5, 2019 15:44
@tgross tgross mentioned this pull request Sep 5, 2019
Merged
@tgross tgross force-pushed the f-e2e-script-checks branch from 4326422 to c2aa805 Compare September 6, 2019 12:33
@tgross tgross force-pushed the f-e2e-script-checks branch from c2aa805 to 863339d Compare September 6, 2019 14:33
@tgross
Copy link
Member Author

tgross commented Sep 6, 2019

With the fix for macOS vs Linux exit codes in f856cd4 and running against a build that includes #6291, this is now passing!

▶ go test -v ./e2e/ -run 'TestE2E/Consul/\*consul\.ScriptChecksE2ETest'
=== RUN   TestE2E
=== RUN   TestE2E/Consul
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest/TestGroupScriptCheck
=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck
=== RUN   TestE2E/Consul_Template
--- PASS: TestE2E (75.87s)
    --- PASS: TestE2E/Consul (75.79s)
        --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest (75.63s)
            --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest/TestGroupScriptCheck (38.20s)
            --- PASS: TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck (37.30s)
    --- PASS: TestE2E/Consul_Template (0.09s)
PASS
ok      github.com/hashicorp/nomad/e2e  78.862s

@preetapan preetapan merged commit eec2033 into master Sep 6, 2019
@preetapan preetapan deleted the f-e2e-script-checks branch September 6, 2019 15:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tgross @schmichael @preetapan