Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script checks: Update needs to update Alloc as well #6291

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 6, 2019

Without updating the alloc during the Update hook, we won't change any values in the script check and the check IDs will mismatch between the script runner and Consul.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@preetapan preetapan added this to the 0.10.0 milestone Sep 6, 2019
@tgross tgross merged commit 8acd253 into master Sep 6, 2019
@tgross tgross deleted the b-script-check-groups branch September 6, 2019 15:18
@tgross tgross mentioned this pull request Sep 6, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants