client: recreate script checks on Update #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-script-check-immutability
branch
from
b01d447 to
7d5040b
Compare
schmichael
reviewed
Sep 4, 2019
schmichael
approved these changes
Sep 4, 2019
tgross
force-pushed
the
b-script-check-immutability
branch
from
dbc4877 to
da342e2
Compare
schmichael
reviewed
Sep 5, 2019
Splitting the immutable and mutable components of the scriptCheck led to a bug where the environment interpolation wasn't being incorporated into the check's ID, which caused the UpdateTTL to update for a check ID that Consul didn't have (because our Consul client creates the ID from the structs.ServiceCheck each time we update). Task group services don't have access to a task environment at creation, so their checks get registered before the check can be interpolated. Use the original check ID so they can be updated.
tgross
force-pushed
the
b-script-check-immutability
branch
from
da342e2 to
38eea0a
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug uncovered in e2e testing in #6252
Splitting the immutable and mutable components of the
scriptCheckled to a bug where the environment interpolation wasn't being incorporated into the check's ID, which caused theUpdateTTLto update for a check ID that Consul didn't have (because our Consul client creates the ID from thestructs.ServiceCheckeach time we update).