feat: Implement solo context connect #863

Ivo-Yankov · 2024-11-22T14:25:12Z

Added a new solo context connect command.
Added new flags for context and clusterName
Added validation error messages and updated error handling for local configuration.

solo context connect accepts the following flags:

--namespace
--context
--cluster-name
--quiet-mode

When a flag is not specified the user will be prompted to input a value. For context a list of all contexts from kubectl config is provided. When quiet=true the default values from kubectl are used.

Currently the command utilizes the promptLocalConfigTask task, which creates the local-config.yaml file if it doesn't exist and prompts for userEmailAddress and for deployments. In a future PR this will be changed so that a different command will be responsible for instantiating the local configuration.

Related Issues

Closes Implement solo context connect part 1 of 2 - updates the LocalConfig by connecting a deployment to a k8s context #754

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2024-11-22T14:28:18Z

Unit Test Results - Linux

1 files ±0 38 suites +2 3s ⏱️ ±0s
116 tests +7 116 ✅ +7 0 💤 ±0 0 ❌ ±0
125 runs +7 125 ✅ +7 0 💤 ±0 0 ❌ ±0

Results for commit d48164c. ± Comparison against base commit 308f39d.

♻️ This comment has been updated with latest results.

github-actions · 2024-11-22T14:28:41Z

Unit Test Results - Windows

1 files ±0 38 suites +2 14s ⏱️ -1s
116 tests +7 116 ✅ +7 0 💤 ±0 0 ❌ ±0
125 runs +7 125 ✅ +7 0 💤 ±0 0 ❌ ±0

Results for commit d48164c. ± Comparison against base commit 308f39d.

♻️ This comment has been updated with latest results.

…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context # Conflicts: # src/commands/node/handlers.ts # src/commands/node/tasks.ts # src/core/k8.ts

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2024-11-26T10:22:12Z

E2E Test Report

13 files ±0 94 suites ±0 55m 40s ⏱️ +11s
200 tests +1 200 ✅ +1 0 💤 ±0 0 ❌ ±0
203 runs +1 203 ✅ +1 0 💤 ±0 0 ❌ ±0

Results for commit d48164c. ± Comparison against base commit 308f39d.

♻️ This comment has been updated with latest results.

codacy-production · 2024-11-26T10:22:33Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.15% (target: -1.00%)	✅ 69.29%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`308f39d`)	14906	12666	84.97%
Head commit (`d48164c`)	15239 (+333)	12926 (+260)	84.82% (-0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#863)	674	467	69.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-11-26T10:23:06Z

Codecov Report

Attention: Patch coverage is 68.54599% with 212 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (308f39d) to head (d48164c).
Report is 96 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/prompts.ts	55.50%	105 Missing ⚠️
src/commands/context/handlers.ts	46.93%	26 Missing ⚠️
src/commands/context/index.ts	51.85%	26 Missing ⚠️
src/commands/context/tasks.ts	85.14%	13 Missing and 2 partials ⚠️
src/core/config/local_config.ts	61.53%	14 Missing and 1 partial ⚠️
src/core/templates.ts	41.17%	10 Missing ⚠️
src/commands/node/tasks.ts	43.75%	9 Missing ⚠️
src/core/k8.ts	92.45%	4 Missing ⚠️
src/commands/index.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   83.81%   83.62%   -0.19%     
==========================================
  Files          49       54       +5     
  Lines       14934    15239     +305     
  Branches     1034     1126      +92     
==========================================
+ Hits        12517    12744     +227     
- Misses       2401     2436      +35     
- Partials       16       59      +43

Files with missing lines	Coverage Δ
src/commands/base.ts	`95.88% <100.00%> (+0.20%)`	⬆️
src/commands/context/flags.ts	`100.00% <100.00%> (ø)`
src/commands/flags.ts	`99.57% <100.00%> (+<0.01%)`	⬆️
src/commands/node/handlers.ts	`81.24% <100.00%> (+0.02%)`	⬆️
src/core/error_messages.ts	`100.00% <100.00%> (ø)`
src/core/helpers.ts	`80.84% <100.00%> (+0.25%)`	⬆️
src/core/task.ts	`100.00% <100.00%> (ø)`
src/core/validator_decorators.ts	`98.00% <ø> (-0.04%)`	⬇️
src/commands/index.ts	`62.50% <33.33%> (-1.66%)`	⬇️
src/core/k8.ts	`89.91% <92.45%> (+0.08%)`	⬆️
... and 7 more

... and 11 files with indirect coverage changes

…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context

src/commands/context/flags.ts

src/commands/context/tasks.ts

src/core/config/local_config.ts

src/core/task.ts

src/core/k8.ts

src/commands/flags.ts

Signed-off-by: Ivo Yankov <[email protected]>

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:30:11Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: solo context use

598efeb

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov self-assigned this Nov 22, 2024

Ivo-Yankov linked an issue Nov 22, 2024 that may be closed by this pull request

Implement solo context connect part 1 of 2 - updates the LocalConfig by connecting a deployment to a k8s context #754

Closed

1 task

Ivo-Yankov added 4 commits November 25, 2024 13:05

Merge branch 'main' into 00754-implement-solo-context-connect-part-1-…

e8c7549

…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context # Conflicts: # src/commands/node/handlers.ts # src/commands/node/tasks.ts # src/core/k8.ts

chore: update context connect command

e5db03f

Signed-off-by: Ivo Yankov <[email protected]>

feat: add descriptive error messages for LocalConfig

74bd85b

Signed-off-by: Ivo Yankov <[email protected]>

chore: format

bd41b5d

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00754-implement-solo-context-connect-part-1-…

35cb512

…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context

Ivo-Yankov marked this pull request as ready for review November 26, 2024 11:03

Ivo-Yankov requested review from leninmehedy and a team as code owners November 26, 2024 11:03

Ivo-Yankov removed a link to an issue Nov 26, 2024

Implement solo context connect part 1 of 2 - updates the LocalConfig by connecting a deployment to a k8s context #754

Closed

1 task

Ivo-Yankov changed the title ~~feat: Implement solo context use~~ feat: Implement solo context connect Nov 26, 2024