Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for using javascript SDK #832

Merged
merged 45 commits into from
Nov 22, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Nov 14, 2024

Description

This pull request changes the following:

Changes to Taskfile.yaml

  • Fix the issue of node name starting from node0 instead of node1
  • Remove installation task per user suggest, since user may already installed own tool chains even not enabled in search path, should not force to install again
  • Add relay deploy and destroy task
  • Add port-forward tasks

Added a unit test to instantiate SDK client to interact with solo

Added SDK.md about how to use Hedera Javascript SDK with solo

https://github.com/hashgraph/solo/blob/00816-D-client-doc-example/docs/content/User/SDK.md

By using environment variable OPERATOR_ID and OPERATOR_KEY, end user can start
running SDK examples immediately after deploying solo.

Related Issues

@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners November 14, 2024 20:07
@JeffreyDallas JeffreyDallas marked this pull request as draft November 14, 2024 20:07
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Test Results - Windows

  1 files  ±0   36 suites  ±0   13s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f01c890. ± Comparison against base commit 5e1c652.

♻️ This comment has been updated with latest results.

@JeffreyDallas JeffreyDallas changed the title 00816 d client doc example feat: update workflow to test relay node, add example for using javascript SDK Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Test Results - Linux

  1 files  ±0   36 suites  ±0   3s ⏱️ -2s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f01c890. ± Comparison against base commit 5e1c652.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Test Report

 16 files  110 suites   1h 2m 57s ⏱️
213 tests 213 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit cf3a6a9.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

E2E Test Report

 16 files  110 suites   1h 18m 9s ⏱️
233 tests 233 ✅ 0 💤 0 ❌
236 runs  236 ✅ 0 💤 0 ❌

Results for commit cc19979.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Nov 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7fa86ad1 95.24%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7fa86ad) Report Missing Report Missing Report Missing
Head commit (cc19979) 14339 12536 87.43%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#832) 21 20 95.24%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (b66fe05) to head (cf3a6a9).
Report is 65 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   87.09%   86.28%   -0.82%     
==========================================
  Files          40       43       +3     
  Lines       12545    13580    +1035     
  Branches      944     1339     +395     
==========================================
+ Hits        10926    11717     +791     
- Misses       1568     1734     +166     
- Partials       51      129      +78     
Files with missing lines Coverage Δ
src/commands/account.ts 76.06% <100.00%> (+0.57%) ⬆️
src/commands/flags.ts 99.53% <100.00%> (+0.04%) ⬆️
src/commands/relay.ts 82.69% <100.00%> (+0.92%) ⬆️
version.ts 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
JeffreyDallas and others added 2 commits November 19, 2024 09:27
@JeffreyDallas JeffreyDallas marked this pull request as ready for review November 20, 2024 20:37
mishomihov00
mishomihov00 previously approved these changes Nov 21, 2024
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed only these files:
.github/workflows/flow-task-test.yaml
.github/workflows/zxc-e2e-test.yaml

@jeromy-cannon
Copy link
Contributor

Is this ready for review? you have it in open status and not draft status. You also have a lot of merge conflicts.

…client-doc-example

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/account.ts
#	test/e2e/commands/account.test.ts
@JeffreyDallas
Copy link
Contributor Author

Is this ready for review? you have it in open status and not draft status. You also have a lot of merge conflicts.

ready for review

tsconfig.json Outdated Show resolved Hide resolved
@JeffreyDallas JeffreyDallas changed the title feat: update workflow to test relay node, add example for using javascript SDK feat: add example for using javascript SDK Nov 22, 2024
@JeffreyDallas
Copy link
Contributor Author

I remove the smoke test from workflow

@jeromy-cannon jeromy-cannon merged commit 1d9452e into main Nov 22, 2024
33 of 37 checks passed
@jeromy-cannon jeromy-cannon deleted the 00816-D-client-doc-example branch November 22, 2024 18:52
swirlds-automation added a commit that referenced this pull request Dec 31, 2024
## [0.32.0](v0.31.1...v0.32.0) (2024-12-31)

### ⚠ BREAKING CHANGES

* update readme with warning about BREAKING CHANGE in this next release (#730)

### Features

* add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341))
* add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e))
* add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7))
* add separate commands for update ([#735](#735)) ([44c3132](44c3132))
* add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0))
* add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad))
* Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38))
* add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b))
* allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e))
* change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496))
* Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d))
* Create remote config  ([#862](#862)) ([e8fe739](e8fe739))
* dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6))
* expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279))
* Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b))
* Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec))
* Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275))
* **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089))
* new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18))
* removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3))
* Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320))
* update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5))
* Update document ([#956](#956)) ([b378937](b378937))
* update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc))
* Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0))

### Bug Fixes

* add delay before calling script ([#955](#955)) ([76f4b81](76f4b81))
* allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78))
* bump chart and hedera version,  re-enable node add ([#985](#985)) ([9cae011](9cae011))
* check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab))
* document typo ([#988](#988)) ([8e4fe04](8e4fe04))
* Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5))
* Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b))
* fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1))
* fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516))
* flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0))
* inconsistent failures ([#866](#866)) ([13ea46d](13ea46d))
* local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1))
* nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6))
* node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5))
* node update with single node ([#981](#981)) ([74285bf](74285bf))
* patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989))
* performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6))
* refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99))
* remote config validation not working ([#967](#967)) ([88c2506](88c2506))
* resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652))
* Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3))
* undefined log output of namespace ([#764](#764)) ([ac15957](ac15957))

### Documentation

* update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants