Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new command to save state files and upload state files #849

Merged
merged 22 commits into from
Nov 25, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Nov 20, 2024

Description

This pull request changes the following:

  • add new subcommand to node command to download state files
  • add new flag to node start to upload zipped state file before node start

Related Issues

@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners November 20, 2024 02:31
@JeffreyDallas JeffreyDallas changed the base branch from main to 00847-D-fix-node-logs November 20, 2024 02:32
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Results - Linux

  1 files  ±0   36 suites  ±0   2s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b949dbb. ± Comparison against base commit 0fb570b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Results - Windows

  1 files  ±0   36 suites  ±0   11s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b949dbb. ± Comparison against base commit 0fb570b.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>
Base automatically changed from 00847-D-fix-node-logs to main November 20, 2024 12:59
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested a review from a team as a code owner November 21, 2024 15:24
…upload-state

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/node/configs.ts
#	src/commands/node/flags.ts
#	test/e2e/commands/node_local_hedera.test.ts
#	test/test_util.ts
Copy link
Contributor

E2E Test Report

 16 files  109 suites   1h 18m 26s ⏱️
232 tests 232 ✅ 0 💤 0 ❌
235 runs  235 ✅ 0 💤 0 ❌

Results for commit ba0d524.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

E2E Test Report

 13 files  ±0   94 suites  ±0   55m 16s ⏱️ + 1m 41s
199 tests +1  199 ✅ +1  0 💤 ±0  0 ❌ ±0 
202 runs  +1  202 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit b949dbb. ± Comparison against base commit 0fb570b.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Nov 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 89.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0fb570b) 14776 12548 84.92%
Head commit (b949dbb) 14934 (+158) 12694 (+146) 85.00% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#849) 137 123 89.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

README.md.template Outdated Show resolved Hide resolved
JeffreyDallas and others added 11 commits November 22, 2024 09:36
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
@JeffreyDallas
Copy link
Contributor Author

Added logic to check account balance after restart from state file

Signed-off-by: Jeffrey Tang <[email protected]>
jeromy-cannon
jeromy-cannon previously approved these changes Nov 22, 2024
…upload-state

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/node/flags.ts
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 88.32117% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.81%. Comparing base (0fb570b) to head (b949dbb).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node/index.ts 0.00% 7 Missing ⚠️
src/core/helpers.ts 81.57% 5 Missing and 2 partials ⚠️
src/commands/mirror_node.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   83.76%   83.81%   +0.04%     
==========================================
  Files          49       49              
  Lines       14804    14934     +130     
  Branches     1457     1314     -143     
==========================================
+ Hits        12401    12517     +116     
- Misses       2259     2321      +62     
+ Partials      144       96      -48     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.57% <100.00%> (+<0.01%) ⬆️
src/commands/node/configs.ts 88.60% <100.00%> (+0.25%) ⬆️
src/commands/node/flags.ts 100.00% <100.00%> (ø)
src/commands/node/handlers.ts 81.21% <100.00%> (+0.84%) ⬆️
src/commands/node/tasks.ts 84.75% <100.00%> (+0.30%) ⬆️
src/commands/mirror_node.ts 76.87% <50.00%> (ø)
src/commands/node/index.ts 34.37% <0.00%> (-0.97%) ⬇️
src/core/helpers.ts 80.59% <81.57%> (+0.07%) ⬆️

... and 17 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit d5a9a18 into main Nov 25, 2024
39 checks passed
@jeromy-cannon jeromy-cannon deleted the 00817-D-upload-state branch November 25, 2024 19:23
swirlds-automation added a commit that referenced this pull request Dec 31, 2024
## [0.32.0](v0.31.1...v0.32.0) (2024-12-31)

### ⚠ BREAKING CHANGES

* update readme with warning about BREAKING CHANGE in this next release (#730)

### Features

* add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341))
* add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e))
* add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7))
* add separate commands for update ([#735](#735)) ([44c3132](44c3132))
* add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0))
* add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad))
* Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38))
* add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b))
* allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e))
* change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496))
* Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d))
* Create remote config  ([#862](#862)) ([e8fe739](e8fe739))
* dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6))
* expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279))
* Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b))
* Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec))
* Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275))
* **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089))
* new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18))
* removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3))
* Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320))
* update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5))
* Update document ([#956](#956)) ([b378937](b378937))
* update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc))
* Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0))

### Bug Fixes

* add delay before calling script ([#955](#955)) ([76f4b81](76f4b81))
* allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78))
* bump chart and hedera version,  re-enable node add ([#985](#985)) ([9cae011](9cae011))
* check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab))
* document typo ([#988](#988)) ([8e4fe04](8e4fe04))
* Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5))
* Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b))
* fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1))
* fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516))
* flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0))
* inconsistent failures ([#866](#866)) ([13ea46d](13ea46d))
* local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1))
* nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6))
* node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5))
* node update with single node ([#981](#981)) ([74285bf](74285bf))
* patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989))
* performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6))
* refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99))
* remote config validation not working ([#967](#967)) ([88c2506](88c2506))
* resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652))
* Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3))
* undefined log output of namespace ([#764](#764)) ([ac15957](ac15957))

### Documentation

* update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to launch a network from saved state
3 participants