feat: removed caching of ConfigManager and its flags #713

jeromy-cannon · 2024-10-18T15:46:35Z

Description

This pull request changes the following:

removed caching of ConfigManager and its flags
changes to remove lint warnings
enhanced update readme workflow so that it will fail correctly if any of the solo calls fail with an error
deduplicated .gitignore (lint warnings)
updated readme template and readme due to impacted changes
added esling: tseslint.configs.recommended
added some missing flags for commands that were getting overlooked due to caching
fail flag prompt if non-interactive terminal detected
made getNodeLogs concurrent
set chai config to not truncate error messages
removed some TODOs by addressing them

Related Issues

Closes Remove ConfigManager caching capabilities to improve user experience #676

github-actions · 2024-10-18T15:49:20Z

Unit Test Results - Linux

1 files 38 suites 9s ⏱️
97 tests 97 ✅ 0 💤 0 ❌
106 runs 106 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

github-actions · 2024-10-18T15:50:12Z

Unit Test Results - Windows

1 files 38 suites 21s ⏱️
97 tests 97 ✅ 0 💤 0 ❌
106 runs 106 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

…d to be fixed Signed-off-by: Jeromy Cannon <[email protected]>

codacy-production · 2024-10-18T16:55:31Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `3d868e6`¹	✅ 86.49%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`3d868e6`)	Report Missing	Report Missing	Report Missing
Head commit (`efede45`)	13109	11379	86.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#713)	74	64	86.49%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

Signed-off-by: Jeromy Cannon <[email protected]>

…guration of type Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2024-10-21T12:16:51Z

E2E Test Report

15 files 96 suites 56m 42s ⏱️
190 tests 190 ✅ 0 💤 0 ❌
193 runs 193 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

codecov · 2024-10-21T12:18:05Z

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (af73379) to head (efede45).
Report is 204 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/prompts.ts	0.00%	6 Missing ⚠️
src/commands/node.ts	70.00%	3 Missing ⚠️
src/commands/init.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   85.32%   85.77%   +0.44%     
==========================================
  Files          38       38              
  Lines       13290    13109     -181     
  Branches      862      903      +41     
==========================================
- Hits        11340    11244      -96     
+ Misses       1925     1840      -85     
  Partials       25       25

Files with missing lines	Coverage Δ
src/commands/flags.ts	`99.49% <100.00%> (ø)`
src/commands/mirror_node.ts	`77.52% <100.00%> (ø)`
src/commands/relay.ts	`81.77% <ø> (-0.10%)`	⬇️
src/core/account_manager.ts	`84.49% <100.00%> (-0.03%)`	⬇️
src/core/config_manager.ts	`92.76% <100.00%> (-0.31%)`	⬇️
src/core/constants.ts	`96.10% <100.00%> (-0.29%)`	⬇️
src/core/dependency_managers/dependency_manager.ts	`96.82% <100.00%> (ø)`
src/core/helpers.ts	`91.09% <100.00%> (+0.10%)`	⬆️
src/core/k8.ts	`90.63% <100.00%> (ø)`
src/core/key_manager.ts	`91.60% <100.00%> (+7.70%)`	⬆️
... and 5 more

... and 1 file with indirect coverage changes

README.md

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:35:41Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon self-assigned this Oct 18, 2024

removed caching of configmanager, expect a lot of test cases that nee…

98e1e9f

…d to be fixed Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 00676-remove-flag-caching branch from 864f750 to 98e1e9f Compare October 18, 2024 16:26

jeromy-cannon added 24 commits October 18, 2024 18:33

enhance update readme to fail when any of the solo calls fail

4da1d9f

Signed-off-by: Jeromy Cannon <[email protected]>

throw error when prompt is ran in non-interactive mode

2a51cfc

Signed-off-by: Jeromy Cannon <[email protected]>

test to see if we are tty

cb8fd4f

Signed-off-by: Jeromy Cannon <[email protected]>

test something

47df8c8

Signed-off-by: Jeromy Cannon <[email protected]>

test something else

206e1c9

Signed-off-by: Jeromy Cannon <[email protected]>

test something else

09a92f1

Signed-off-by: Jeromy Cannon <[email protected]>

fix script

106ff43

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

01d5148

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

12bc10f

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

aa3aa07

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

a4b9eae

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

40cccc0

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

16c4c27

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

3caf37b

Signed-off-by: Jeromy Cannon <[email protected]>

try something else?

ff7efd7

Signed-off-by: Jeromy Cannon <[email protected]>

remove duplicates reported in linter warnings

76711fb

Signed-off-by: Jeromy Cannon <[email protected]>

add all needed argvs

a2e8546

Signed-off-by: Jeromy Cannon <[email protected]>

fix warnings and errors

952895a

Signed-off-by: Jeromy Cannon <[email protected]>

update readme

555b75e

Signed-off-by: Jeromy Cannon <[email protected]>

check version was showing as not used, but it was due to a miss confi…

7702112

…guration of type Signed-off-by: Jeromy Cannon <[email protected]>

missing some values and defaults

31e5ed1

Signed-off-by: Jeromy Cannon <[email protected]>

removed duplicate relay call

2eb5a34

Signed-off-by: Jeromy Cannon <[email protected]>

go ahead and update readme with it ran locally

5eb142c

Signed-off-by: Jeromy Cannon <[email protected]>

rename to follow our convention

4412a2b

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon added 3 commits October 20, 2024 22:33

provide more info when mocha or chai fails

50b2f00

Signed-off-by: Jeromy Cannon <[email protected]>

fix keymanager test

ea68382

Signed-off-by: Jeromy Cannon <[email protected]>

don't need async and done

efede45

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon marked this pull request as ready for review October 21, 2024 13:14

jeromy-cannon requested review from a team and leninmehedy as code owners October 21, 2024 13:14

jeromy-cannon requested review from Ivo-Yankov, nathanklick, JeffreyDallas and instamenta October 21, 2024 13:14

instamenta approved these changes Oct 21, 2024

View reviewed changes

JeffreyDallas reviewed Oct 21, 2024

View reviewed changes

README.md Show resolved Hide resolved

JeffreyDallas reviewed Oct 21, 2024

View reviewed changes

README.md Show resolved Hide resolved

JeffreyDallas reviewed Oct 21, 2024

View reviewed changes

README.md Show resolved Hide resolved

jeromy-cannon merged commit 76a61e3 into main Oct 21, 2024
42 of 43 checks passed

jeromy-cannon deleted the 00676-remove-flag-caching branch October 21, 2024 15:20

swirlds-automation added the released label Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: removed caching of ConfigManager and its flags #713

feat: removed caching of ConfigManager and its flags #713

jeromy-cannon commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

codacy-production bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading

swirlds-automation commented Dec 31, 2024

feat: removed caching of ConfigManager and its flags #713

feat: removed caching of ConfigManager and its flags #713

Conversation

jeromy-cannon commented Oct 18, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Oct 18, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Oct 18, 2024 • edited Loading

Unit Test Results - Windows

codacy-production bot commented Oct 18, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

github-actions bot commented Oct 21, 2024 • edited Loading

E2E Test Report

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

swirlds-automation commented Dec 31, 2024

jeromy-cannon commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

codacy-production bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading