fix: fixed genesis-network.json file lock issue #1074

jeromy-cannon · 2024-12-31T16:48:03Z

Description

This pull request changes the following:

fixed genesis-network.json file lock issue
commented out solo chart and hedera version overrides in taskfile
updated taskfile to work without solo chart and hedera version overrides
updated taskfile to clean up tmp files
updated Solo to use hedera version default when no release tag is provided

Related Issues

Closes Solo-deployed CNode throws error: data/config/.archive/genesis-network.json: Device or resource busy #1027

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2024-12-31T16:49:41Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ -1s
227 tests - 1 227 ✅ - 1 0 💤 ±0 0 ❌ ±0
232 runs - 1 232 ✅ - 1 0 💤 ±0 0 ❌ ±0

Results for commit acece9e. ± Comparison against base commit b9f2e1c.

This pull request removes 1 test.

should fail when no releaseTag is provided ‑ ProfileManager prepareConfigText should fail when no releaseTag is provided

github-actions · 2024-12-31T16:50:37Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 13s ⏱️ -1s
227 tests - 1 227 ✅ - 1 0 💤 ±0 0 ❌ ±0
232 runs - 1 232 ✅ - 1 0 💤 ±0 0 ❌ ±0

Results for commit acece9e. ± Comparison against base commit b9f2e1c.

This pull request removes 1 test.

should fail when no releaseTag is provided ‑ ProfileManager prepareConfigText should fail when no releaseTag is provided

github-actions · 2024-12-31T17:31:03Z

E2E Test Report

16 files ±0 121 suites ±0 1h 19m 24s ⏱️ - 1m 59s
258 tests ±0 258 ✅ ±0 0 💤 ±0 0 ❌ ±0
261 runs ±0 261 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit acece9e. ± Comparison against base commit b9f2e1c.

♻️ This comment has been updated with latest results.

codacy-production · 2024-12-31T17:31:19Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.02% (target: -1.00%)	✅ 90.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`b9f2e1c`)	19891	17040	85.67%
Head commit (`acece9e`)	19922 (+31)	17071 (+31)	85.69% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1074)	10	9	90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-12-31T17:32:11Z

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (b9f2e1c) to head (acece9e).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/templates.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1074    +/-   ##
========================================
  Coverage   84.82%   84.83%            
========================================
  Files          76       76            
  Lines       19918    19922     +4     
  Branches     1597     1255   -342     
========================================
+ Hits        16896    16900     +4     
- Misses       2922     3000    +78     
+ Partials      100       22    -78

Files with missing lines	Coverage Δ
src/commands/flags.ts	`73.53% <100.00%> (ø)`
src/core/profile_manager.ts	`97.33% <100.00%> (+<0.01%)`	⬆️
src/core/templates.ts	`73.04% <75.00%> (+0.19%)`	⬆️

... and 26 files with indirect coverage changes

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:26:05Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

fixed genesis-network.json file lock issue

acece9e

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon requested review from leninmehedy and a team as code owners December 31, 2024 16:48

jeromy-cannon requested review from Ivo-Yankov, nathanklick, JeffreyDallas and instamenta December 31, 2024 16:48

nathanklick approved these changes Dec 31, 2024

View reviewed changes

jeromy-cannon merged commit e590516 into main Dec 31, 2024
43 checks passed

jeromy-cannon deleted the 01027-genesis-archive branch December 31, 2024 18:07

swirlds-automation added the released label Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixed genesis-network.json file lock issue #1074

fix: fixed genesis-network.json file lock issue #1074

jeromy-cannon commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024 •

edited

Loading

codacy-production bot commented Dec 31, 2024

codecov bot commented Dec 31, 2024 •

edited

Loading

swirlds-automation commented Dec 31, 2024

fix: fixed genesis-network.json file lock issue #1074

fix: fixed genesis-network.json file lock issue #1074

Conversation

jeromy-cannon commented Dec 31, 2024

Description

Related Issues

github-actions bot commented Dec 31, 2024

Unit Test Results - Linux

github-actions bot commented Dec 31, 2024

Unit Test Results - Windows

github-actions bot commented Dec 31, 2024 • edited Loading

E2E Test Report

codacy-production bot commented Dec 31, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Dec 31, 2024 • edited Loading

Codecov Report

swirlds-automation commented Dec 31, 2024

github-actions bot commented Dec 31, 2024 •

edited

Loading

codecov bot commented Dec 31, 2024 •

edited

Loading