Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Gradle and module versions #17232

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

jjohannes
Copy link
Collaborator

Description:

  • Gradle 8.12
  • com.google.jimfs:jimfs:1.3.0 - now has an Automatic-Module-Name
  • commons-codec:commons-codec:1.17.1 - now has a module-info
  • org.jetbrains:annotations:26.0.1 - now has a module-info

andrewb1269hg
andrewb1269hg previously approved these changes Jan 6, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PavelSBorisov
PavelSBorisov previously approved these changes Jan 6, 2025
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes dismissed stale reviews from PavelSBorisov and andrewb1269hg via 129c39b January 6, 2025 16:58
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (8f2208a) to head (129c39b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17232      +/-   ##
============================================
+ Coverage     64.34%   64.41%   +0.07%     
- Complexity    20945    20966      +21     
============================================
  Files          2555     2555              
  Lines         96169    96169              
  Branches      10054    10054              
============================================
+ Hits          61878    61947      +69     
+ Misses        30653    30585      -68     
+ Partials       3638     3637       -1     

see 21 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 6, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8f2208a) 95932 65324 68.09%
Head commit (129c39b) 95932 (+0) 65392 (+68) 68.16% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17232) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jjohannes jjohannes merged commit 25cbbf1 into main Jan 6, 2025
50 checks passed
@jjohannes jjohannes deleted the gradle-and-module-updates branch January 6, 2025 19:39
netopyr added a commit that referenced this pull request Jan 7, 2025
* main:
  ci: run swirlds-platform-tests as part of CI builds (#17121)
  test: Token bulk operations and fees tests (#16892)
  fix: change == to .equals for Bytes.EMPTY and other non-primitive types (#17213)
  build(deps): bump webcompare from 2.1.5 to 2.1.7 in /hiero-dependency-versions (#17207)
  build: bump Gradle and module versions  (#17232)
  refactor: 16569 Rename `MerkleStateLifecycles` to `StateLifecycles` (#17193)
  build(deps): bump grpc from 1.64.0 to 1.69.0 in /hiero-dependency-versions (#17209)
  build(deps): bump io.github.classgraph:classgraph from 4.8.65 to 4.8.179 in /hiero-dependency-versions (#17208)
  build(deps): bump com.github.ben-manes.caffeine:caffeine from 3.1.1 to 3.1.8 in /hiero-dependency-versions (#17206)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/state/StateLifecyclesImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants