feat: Uploader Cloud Storage Interface #17042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
…erface' into 16973-uploader-cloud-storage-interface # Conflicts: # gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
…ion' into 16973-uploader-cloud-storage-interface
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
nathanklick
reviewed
Dec 12, 2024
.../hedera-app/src/main/java/com/hedera/node/app/blocks/cloud/uploader/CloudBucketUploader.java
Outdated
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/blocks/cloud/uploader/CloudBucketUploader.java
Outdated
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/blocks/cloud/uploader/CloudBucketUploader.java
Outdated
Show resolved
Hide resolved
...ode/hedera-app/src/main/java/com/hedera/node/app/uploader/credentials/BucketCredentials.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
reviewed
Jan 6, 2025
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
thomas-swirlds-labs
requested review from
a team,
rbair23,
dalvizu,
poulok,
netopyr,
Nana-EC,
SimiHunjan and
steven-sheehy
as code owners
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
Signed-off-by: Thomas Moran <[email protected]>
jjohannes
approved these changes
Jan 8, 2025
| private String calculateMD5Hash(Path filePath) throws IOException, NoSuchAlgorithmException { | ||
| // Calculate MD5 hash | ||
| byte[] fileBytes = Files.readAllBytes(filePath); // Read the file content as bytes | ||
| MessageDigest md = MessageDigest.getInstance("MD5"); |
There was a problem hiding this comment.
Perhaps we can have the MessageDigest instance created once for a MinioBucketUploader?
| .build()); | ||
| return null; | ||
| }, | ||
| maxRetryAttempts > 0 ? maxRetryAttempts : 3); |
There was a problem hiding this comment.
We already have the default set to 3 in BlockStreamConfig, do we need this conditional here?
| BucketConfigurationManager bucketConfigurationManager, | ||
| @CommonExecutor ExecutorService executor, | ||
| ConfigProvider configProvider) { | ||
| List<CompleteBucketConfig> completeBucketConfigs = bucketConfigurationManager.getCompleteBucketConfigs(); |
There was a problem hiding this comment.
Why provide a list of bucket configs if below we always call .getFirst()?
|
Closing as will not be implementing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #16973