fix: change == to .equals for Bytes.EMPTY and other non-primitive types #17213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Rader <[email protected]>
kimbor
changed the title
kimbor
changed the title
Signed-off-by: Kim Rader <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17213 +/- ##
=========================================
Coverage 64.33% 64.34%
- Complexity 20942 20945 +3
=========================================
Files 2555 2555
Lines 96169 96169
Branches 10054 10054
=========================================
+ Hits 61873 61876 +3
Misses 30655 30655
+ Partials 3641 3638 -3
... and 11 files with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
povolev15
approved these changes
Jan 6, 2025
netopyr
added a commit
that referenced
this pull request
Jan 7, 2025
* main: ci: run swirlds-platform-tests as part of CI builds (#17121) test: Token bulk operations and fees tests (#16892) fix: change == to .equals for Bytes.EMPTY and other non-primitive types (#17213) build(deps): bump webcompare from 2.1.5 to 2.1.7 in /hiero-dependency-versions (#17207) build: bump Gradle and module versions (#17232) refactor: 16569 Rename `MerkleStateLifecycles` to `StateLifecycles` (#17193) build(deps): bump grpc from 1.64.0 to 1.69.0 in /hiero-dependency-versions (#17209) build(deps): bump io.github.classgraph:classgraph from 4.8.65 to 4.8.179 in /hiero-dependency-versions (#17208) build(deps): bump com.github.ben-manes.caffeine:caffeine from 3.1.1 to 3.1.8 in /hiero-dependency-versions (#17206) # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/state/StateLifecyclesImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates all object comparisons to use equals instead of == except for a few instances where reference comparisons are per design.
Related issue(s):
Fixes #16639
Notes for reviewer:
A zero-length PBJ Bytes is not necessarily Bytes.EMPTY so nothing should depend on object equality with Bytes.EMPTY. Using == for comparing objects is an anti-pattern in Java.