Must measure output size with Rune.ColumnWidth

[migueldeicaza]

Many characters that take up two slots are not properly rendered as we render those two, but do not fully fill the requested region. Need to use Rune.ColumnWidth to compute the current position.

[tig]

@migueldeicaza do you have a test case for this?

[tig]

FWIW, this is a disaster. I dare anyone to follow the discussions w.r.t. wide unicode chars in Windows Terminal land and successfully follow along... Or have any idea what we should do.

Examples:

• Consider making ConPTY and Windows Terminal treat all ambiguous-width characters as 1 cell instead of asking the font microsoft/terminal#2066
• TermControl: force all ambiguous glyphs to be narrow microsoft/terminal#2928
• Certain "emoji" are still half-sized microsoft/terminal#900
• Font Glyphs are cut off by the Windows Terminal microsoft/terminal#5095 (comment)

[tig]

FWIW, I believe at some point I modified the code (in ConsoleDriver? to explicitly ignore Runes with ColumnWidth > 1 and print the default char as a work around of this issue until it can be addressed correctly. In #949, it appears @BDisp discovered that I missed a case.

[BDisp]

@migueldeicaza I think maybe it's time to use System.Text.Rune.

[BDisp]

I submitted a PR at gui-cs/NStack#48 to be able to control what kind of rune is being passed to AddRune. I hope that @migueldeicaza takes into account to be able to come up with a solution.

[migueldeicaza]

The patch from @BDisp is now merged and should be on the new NStack.Core

[BDisp]

@migueldeicaza there is another PR (gui-cs/NStack#52) that fixes the "Chess Symbols (U+1fa00-1fa0f)". Thanks.

[migueldeicaza]

Merged - I will release a new NStack in the morning.