Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #51. Chess Symbols (U+1fa00-1fa0f) not returning Column Width bigger than 1. #52

Merged
merged 6 commits into from
Dec 8, 2020

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Oct 30, 2020

No description provided.

@migueldeicaza
Copy link
Collaborator

Question: the removal of ValueTuple, this will still work on .NET Framework?

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 25, 2020

Yes it's working on .NET Framework 472. But it's preferable that you check that too, please.

@BDisp BDisp changed the title Fixes #51. Value.Tuple is not needed and added more Rune unit tests. Fixes #51. Chess Symbols (U+1fa00-1fa0f) not returning Column Width bigger than 1. Nov 26, 2020
@BDisp
Copy link
Collaborator Author

BDisp commented Nov 26, 2020

@migueldeicaza I reverted the removed System.ValueTuple to not breaking anything. I only updated the version for the NStack API.

@BDisp BDisp marked this pull request as draft November 26, 2020 20:19
@BDisp BDisp marked this pull request as ready for review November 26, 2020 20:50
@migueldeicaza migueldeicaza merged commit 6d8685f into gui-cs:master Dec 8, 2020
@BDisp BDisp deleted the value-tuple-removed branch December 8, 2020 09:17
@migueldeicaza
Copy link
Collaborator

Uploaded, NuGet should have it available soon, version 0.16

@BDisp
Copy link
Collaborator Author

BDisp commented Dec 8, 2020

Thanks @migueldeicaza .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants