Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese is displayed as overlapping #225

Closed
maikebing opened this issue Jul 6, 2019 · 12 comments
Closed

Chinese is displayed as overlapping #225

maikebing opened this issue Jul 6, 2019 · 12 comments
Labels

Comments

@maikebing
Copy link


   //Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
      //  Application.UseSystemConsole = true;
		Application.Init ();

image


   Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
     Application.UseSystemConsole = true;
		Application.Init ();

image

But the mouse can't be used.

@tig tig added the bug label May 24, 2020
@chengts95
Copy link

Actually, the Chinese characters become squares in the latest version,
image
They can be displayed correctly in v0.81.

@BDisp
Copy link
Collaborator

BDisp commented Oct 16, 2020

There is a bug in the code that not letting unicode to process if Rune.ColumnWidth is greater than 1. That the case of chinese characters. Since the chinese language has installed the chinese characters should be outputed. If the system don't recognize the charater then let the SO output the default string, perhaps "?". I'll submit a PR to fix this.

chinese-unicode

@BDisp
Copy link
Collaborator

BDisp commented Oct 16, 2020

Here a screenshot on the Linux.

chinese-linux

@BDisp
Copy link
Collaborator

BDisp commented Oct 16, 2020

On Mac I can print chinese on the prompt but not in the app. I think maybe is related with the #949.

chinese-mac-terminal

chinese-mac

@chengts95
Copy link

Nice Fix! Thanks, bro!

@chengts95
Copy link

Looks like typing Chinese is still a problem, I get nothing shown up on windows.

@BDisp
Copy link
Collaborator

BDisp commented Oct 17, 2020

Do you tried with my PR? If you did, do you have the chinese font installed?

@chengts95
Copy link

IME Input is not working, the display is ok.

@chengts95
Copy link

image
The characters are shown in the menu bar, however, no Chinese character can be typed in login or demo text editor.

@BDisp
Copy link
Collaborator

BDisp commented Oct 17, 2020

Ah ok. I didn't test the input. I only did copy /paste. Well I never wrote Chinese before and I don't know if I can typed with my keyboard. I will try.

@chengts95
Copy link

chengts95 commented Oct 18, 2020

That only happens on Windows, on Ubuntu 20.04, it works well. Maybe it is related to IME and console implementation on Windows.
image

@chengts95
Copy link

However, in the text editor demo the typing becomes abnormal. I believe it is another issue for multi-byte characters in TextView. The TextField is OK.

@tig tig closed this as completed in b56edac Oct 20, 2020
tig added a commit that referenced this issue Oct 20, 2020
Fixes #225 and maybe #41. Allowing Rune.ColumnWidth greater than one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants