build: add pre-push hook #2199
Merged
build: add pre-push hook #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertbates
reviewed
Mar 22, 2024
Co-authored-by: Rupert Bates <[email protected]>
jamesgorrie
reviewed
Mar 25, 2024
| @@ -0,0 +1 @@ | |||
| pnpm --filter cdk lint && pnpm --filter cdk test | |||
There was a problem hiding this comment.
With linting - most IDEs support fix on save, might be worth looking at that, it shortens the feedback loop even more.
There was a problem hiding this comment.
Interesting idea - something for a next PR optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds a pre-push hook that runs the cdk lint & tests before push.
This can hopefully shorten the feedback loop between development and deployment when we forget to update the snapshot tests or when there are linting errors.