revert pr #2174 due to failed deployment #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #2174
This lambda was moved over in the CFN from
membershiptosupportstacks in the above PR.However it seems like the riffraff is still down as stack:
membershipThis means that when it tries to deploy the cloudformation doesn't deploy as it can't find the jar.
I think it didn't deploy when it was first merged due to merge conflicts that github couldn't detect but they broke the build. It looks like the next PR to merge inadvertantly fixed the conflict #2199
A quick fix might be to update the riffraff stack to match the cfn, but it seems like the stripe console is still set up to use the old API gateway, so I'm worried that a successful deploy might change the endpoint url (eg to something.support.guardianapis.com or similar)
I think the safest option is to revert for now and then when more people are around after easter we can make a new PR with the original changes plus any needed fix in.