Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop running cdk tests and linting on every push #2546

Merged
merged 2 commits into from
Nov 14, 2024
Merged

stop running cdk tests and linting on every push #2546

merged 2 commits into from
Nov 14, 2024

Conversation

johnduffell
Copy link
Member

@johnduffell johnduffell commented Nov 13, 2024 •
edited
Loading

I was working on another project recently and noticed the pushes were really quick. I noticed they take around 20s on this project even with trivial changes. After looking into why they are so slow, it seems like we are running CDK linting and tests on every push.

This PR changes it so it only runs when you change cdk/* so otherwise push finishes before I even click away (1-2 seconds).

Script courtesy of @AndreaDiotallevi via AI!

Original PR adding the check is here #2199

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::generate-product-catalog to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::product-switch-api to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9377 of support-service-lambdas::batch-email-sender to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9377 of support-service-lambdas::single-contribution-salesforce-writes to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::update-supporter-plus-amount to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::salesforce-disaster-recovery-health-check to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::alarms-handler to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9377 of support-service-lambdas::cancellation-sf-cases-api to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::ticket-tailor-webhook to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::salesforce-disaster-recovery to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::zuora-salesforce-link-remover to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9610 of support-service-lambdas::discount-api to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9377 of support-service-lambdas::stripe-webhook-endpoints to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Deploy build 9377 of support-service-lambdas::new-product-api to CODE

All deployment options

From guardian/actions-riff-raff.

@AndreaDiotallevi
Copy link
Contributor

AndreaDiotallevi commented Nov 14, 2024 •
edited
Loading

For me it was the opposite.

I was working with CDK and I lost so much time waiting for the CI to fail in GitHub.

So I'd say, we can improve it by running CDK tests only if files inside the CDK folder have changed?

Also suggested by @andrewHEguardian & @rupertbates

@github-actions GitHub Actions
Copy link
Contributor

Deploy build 9610 of support-service-lambdas::press-reader-entitlements to CODE

All deployment options

From guardian/actions-riff-raff.

AndreaDiotallevi
AndreaDiotallevi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@AndreaDiotallevi AndreaDiotallevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up - good improvement!

@johnduffell johnduffell merged commit cdb2e3f into main Nov 14, 2024
47 checks passed
@johnduffell johnduffell deleted the jd-speed-up-push branch November 14, 2024 17:44
@johnduffell johnduffell mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaDiotallevi AndreaDiotallevi AndreaDiotallevi approved these changes

@rupertbates rupertbates Awaiting requested review from rupertbates

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnduffell @AndreaDiotallevi