-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-byline fields #27698
Add multi-byline fields #27698
Conversation
@simonbyford I think we'll need to bump content-api-scala-client in facia-scala-client, and then bump facia-scala-client here, to get the build to pass. Who knew dependency cascades weren't just a JavaScript problem 😄 I've raised a PR: guardian/facia-scala-client#341 |
37c7cc2
to
0d7a688
Compare
Ah hello! Sorry I missed this PR, I think I may have duplicated your work a bit as I've opened #27705 - actually that PR is only bumping CAPI & FAPI client versions, not adding the additonal code you've added around reading the multi-author bylines in We might want to stack this PR on top of #27705, what do you think? |
I don't mind! Happy to keep them separate if yours is likely to be merged soon? Then I can just rebase |
0d7a688
to
ab56383
Compare
Seen on FRONTS-PROD, ADMIN-PROD (merged by @simonbyford 1 hour, 42 minutes and 13 seconds ago)
|
What does this change?
This adds support for the new fields included in Multi-byline fields.
These fields have been available content-api-client since v33.0.0.
dotcom-rendering is already able to render these fields, since guardian/dotcom-rendering#12496
Screenshots