Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-byline fields #27698

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,10 @@ case class ListItem(
title: Option[String],
bio: Option[String],
endNote: Option[String],
contributorIds: Option[scala.collection.Seq[String]],
byline: Option[String],
bylineHtml: Option[String],
contributorImageOverrideUrl: Option[String],
) extends PageElement
object ListItem {
implicit val listItemWrites: Writes[ListItem] = Json.writes[ListItem]
Expand Down Expand Up @@ -1590,6 +1594,10 @@ object PageElement {
title = item.title,
bio = item.bio,
endNote = item.endNote,
contributorIds = item.contributorIds,
byline = item.byline,
bylineHtml = item.bylineHtml,
contributorImageOverrideUrl = item.contributorImageOverrideUrl,
)
}

Expand Down
6 changes: 3 additions & 3 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ object Dependencies {
val identityLibVersion = "4.31"
val awsVersion = "1.12.758"
val awsSdk2Version = "2.26.27"
val capiVersion = "32.0.1"
val faciaVersion = "13.1.0"
val capiVersion = "33.0.0"
val faciaVersion = "14.0.0"
val dispatchVersion = "0.13.1"
val romeVersion = "1.0"
val jerseyVersion = "1.19.4"
Expand All @@ -32,7 +32,7 @@ object Dependencies {
val commonsIo = "commons-io" % "commons-io" % "2.16.1"
val cssParser = "net.sourceforge.cssparser" % "cssparser" % "0.9.30"
val contentApiClient = "com.gu" %% "content-api-client" % capiVersion
val contentApiModelsJson = "com.gu" %% "content-api-models-json" % "25.1.0"
val contentApiModelsJson = "com.gu" %% "content-api-models-json" % "26.0.0"
val dfpAxis = "com.google.api-ads" % "dfp-axis" % "5.6.0"
val faciaFapiScalaClient = "com.gu" %% "fapi-client-play30" % faciaVersion
val identityCookie = "com.gu.identity" %% "identity-cookie" % identityLibVersion
Expand Down
Loading