Bump CAPI scala client to v33 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyford
approved these changes
Jan 8, 2025
rtyley
added a commit
to guardian/frontend
that referenced
this pull request
Jan 9, 2025
With guardian/facia-scala-client#287, the Facia client has been updated so that it can take advantage of ETag-caching, using the https://github.com/guardian/etag-caching library already used in Frontend since August 2023 with #26338. As some changes were necessary to the `etag-caching` library to facilitate this, we need to update the version of `etag-caching` used by Frontend to v7.0.0. We also need to use an updated version of CAPI, as the CAPI version used by Facia was recently updated with guardian/facia-scala-client#341. Although this change upgrades to the latest version of the Facia client, it doesn't take advantage of the new ETag-caching support there - that can come in a later PR, as it does involve switching to AWS SDK v2 (not everywhere in Frontend, just for where we use the Facia client, but it's still a significant change as the AWS STS credential creation has got more elaborate with AWS SDK v2).
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bump to support changes to to the CAPI Scala Client:
We are bumping the CAPI Scala client in frontend, we'll also beed to bump facia-scala-client to get the build to pass: guardian/frontend#27698