Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossword design #437

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add crossword design #437

merged 1 commit into from
Jan 7, 2025

Conversation

SiAdcock
Copy link
Contributor

@SiAdcock SiAdcock commented Jan 7, 2025

What does this change?

We are updating DCR to support crosswords. To create a new layout in DCR, we need to extend the Design model to support crosswords.

This change also has to be made in the CAPI client because frontend uses it to parse the CAPI data into the Format type, before sending this on to DCR.

How to test

For a crossword page, check the JSON data passed from frontend to DCR (example). The format should be defined as:

"format": {
  "design": "CrosswordDesign",
  "theme": "LifestylePillar",
  "display": "StandardDisplay"
}

@SiAdcock SiAdcock requested a review from a team as a code owner January 7, 2025 07:07
@SiAdcock SiAdcock requested a review from JamieB-gu January 7, 2025 07:07
Copy link

github-actions bot commented Jan 7, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 6bc17b8. ± Comparison against base commit 6720a1f.

♻️ This comment has been updated with latest results.

@domlander
Copy link

Can a test be added in CapiModelEnrichmentTest.scala? It looks like other design types have at least one corresponding test in this file.

@sndrs sndrs added this to the Decommission Frontend Rendering milestone Jan 7, 2025
@sndrs sndrs linked an issue Jan 7, 2025 that may be closed by this pull request
@SiAdcock
Copy link
Contributor Author

SiAdcock commented Jan 7, 2025

Can a test be added in CapiModelEnrichmentTest.scala? It looks like other design types have at least one corresponding test in this file.

This PR adds a Design rather than a DesignType. I find myself struggling to articulate the discrepancy between them, but there are fewer DesignTypes than there are Designs. This is why I didn't add a test to this file.

Let me know if you think we also need a Crossword DesignType

@SiAdcock SiAdcock force-pushed the sa-crossword-design branch from 3e395f6 to 6bc17b8 Compare January 7, 2025 10:55
@sndrs sndrs linked an issue Jan 7, 2025 that may be closed by this pull request
@SiAdcock SiAdcock merged commit 8361bf8 into main Jan 7, 2025
2 checks passed
@gu-scala-library-release
Copy link
Contributor

@SiAdcock has published a preview version of this PR with release workflow run #70, based on commit 6bc17b8:

32.1.0-PREVIEW.sa-crossword-design.2025-01-07T1545.6bc17b8f

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the sa-crossword-design branch, or use the GitHub CLI command:

gh workflow run release.yml --ref sa-crossword-design

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add CrosswordDesign to CAPI client
3 participants