-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossword design #437
Add crossword design #437
Conversation
01f7325
to
3e395f6
Compare
Can a test be added in CapiModelEnrichmentTest.scala? It looks like other design types have at least one corresponding test in this file. |
client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala
Outdated
Show resolved
Hide resolved
This PR adds a Let me know if you think we also need a |
3e395f6
to
6bc17b8
Compare
@SiAdcock has published a preview version of this PR with release workflow run #70, based on commit 6bc17b8: 32.1.0-PREVIEW.sa-crossword-design.2025-01-07T1545.6bc17b8f Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the sa-crossword-design branch, or use the GitHub CLI command: gh workflow run release.yml --ref sa-crossword-design Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
What does this change?
We are updating DCR to support crosswords. To create a new layout in DCR, we need to extend the Design model to support crosswords.
This change also has to be made in the CAPI client because frontend uses it to parse the CAPI data into the
Format
type, before sending this on to DCR.How to test
For a crossword page, check the JSON data passed from frontend to DCR (example). The format should be defined as: