Refactor expansion in Discussion

[oliverlloyd]

What does this change?

This PR helps with #4297 and is related to guardian/discussion-rendering#559 but does not fix or depend on either

Here we refactor expansion in Discussion.

1. Use type Props to match convention
2. Remove unused expanded prop
3. Stop logging unused metrics to GA (we have completed the Emotion 11 migration)
4. Always reload the Discussion component when a permalink is clicked (for more reliability)

[github-actions]

Size Change: -406 B (0%)

Total Size: 1.51 MB

Filename	Size	Change
dotcom-rendering/dist/DiscussionContainer-importable.js	5.72 kB	-145 B (-2%)
dotcom-rendering/dist/DiscussionContainer-importable.legacy.js	6.01 kB	-143 B (-2%)
dotcom-rendering/dist/frontend.server.js	404 kB	-118 B (0%)

ℹ️ View Unchanged

Filename	Size
dotcom-rendering/dist/1189.js	3.58 kB
dotcom-rendering/dist/1451.js	21.1 kB
dotcom-rendering/dist/1451.legacy.js	21.8 kB
dotcom-rendering/dist/1576.legacy.js	3.21 kB
dotcom-rendering/dist/1956.js	4.13 kB
dotcom-rendering/dist/2550.legacy.js	4.35 kB
dotcom-rendering/dist/2839.legacy.js	3.67 kB
dotcom-rendering/dist/288.js	2.84 kB
dotcom-rendering/dist/2947.js	2.59 kB
dotcom-rendering/dist/2947.legacy.js	2.67 kB
dotcom-rendering/dist/4109.legacy.js	2.91 kB
dotcom-rendering/dist/4475.js	4.64 kB
dotcom-rendering/dist/5080.js	5.28 kB
dotcom-rendering/dist/5080.legacy.js	5.43 kB
dotcom-rendering/dist/5226.js	5.5 kB
dotcom-rendering/dist/5226.legacy.js	5.91 kB
dotcom-rendering/dist/53.js	4.12 kB
dotcom-rendering/dist/53.legacy.js	4.13 kB
dotcom-rendering/dist/5356.js	32.3 kB
dotcom-rendering/dist/5356.legacy.js	30.2 kB
dotcom-rendering/dist/6021.js	3.95 kB
dotcom-rendering/dist/6021.legacy.js	4.19 kB
dotcom-rendering/dist/6188.js	4.46 kB
dotcom-rendering/dist/6398.js	3.07 kB
dotcom-rendering/dist/6400.js	21.5 kB
dotcom-rendering/dist/6400.legacy.js	21.5 kB
dotcom-rendering/dist/7388.legacy.js	2.79 kB
dotcom-rendering/dist/7532.legacy.js	4.71 kB
dotcom-rendering/dist/7576.js	4.21 kB
dotcom-rendering/dist/7576.legacy.js	4.38 kB
dotcom-rendering/dist/7756.js	3.7 kB
dotcom-rendering/dist/7756.legacy.js	3.73 kB
dotcom-rendering/dist/7800.js	11.2 kB
dotcom-rendering/dist/7809.legacy.js	2.69 kB
dotcom-rendering/dist/8129.legacy.js	11.8 kB
dotcom-rendering/dist/8525.legacy.js	4.8 kB
dotcom-rendering/dist/9804.js	2.76 kB
dotcom-rendering/dist/9804.legacy.js	2.87 kB
dotcom-rendering/dist/AlreadyVisited-importable.js	4.5 kB
dotcom-rendering/dist/AlreadyVisited-importable.legacy.js	4.5 kB
dotcom-rendering/dist/atomIframe.js	1.74 kB
dotcom-rendering/dist/atomIframe.legacy.js	2.01 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.js	442 B
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.js	501 B
dotcom-rendering/dist/bootCmp.js	7.76 kB
dotcom-rendering/dist/bootCmp.legacy.js	11.3 kB
dotcom-rendering/dist/Branding-importable.js	2.41 kB
dotcom-rendering/dist/Branding-importable.legacy.js	2.44 kB
dotcom-rendering/dist/braze-web-sdk-core.js	36.1 kB
dotcom-rendering/dist/braze-web-sdk-core.legacy.js	36.1 kB
dotcom-rendering/dist/BrazeMessaging-importable.js	9.6 kB
dotcom-rendering/dist/BrazeMessaging-importable.legacy.js	10.4 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.js	6.94 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.legacy.js	7.3 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.js	246 B
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.js	256 B
dotcom-rendering/dist/CommentCount-importable.js	6.14 kB
dotcom-rendering/dist/CommentCount-importable.legacy.js	6.29 kB
dotcom-rendering/dist/CommercialMetrics-importable.js	4.27 kB
dotcom-rendering/dist/CommercialMetrics-importable.legacy.js	4.63 kB
dotcom-rendering/dist/coreVitals.js	3.91 kB
dotcom-rendering/dist/coreVitals.legacy.js	4.21 kB
dotcom-rendering/dist/DiscussionMeta-importable.js	6.59 kB
dotcom-rendering/dist/DiscussionMeta-importable.legacy.js	6.76 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.js	2.93 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.js	3.03 kB
dotcom-rendering/dist/dynamicImport.js	2.85 kB
dotcom-rendering/dist/dynamicImport.legacy.js	3.14 kB
dotcom-rendering/dist/EditionDropdown-importable.js	3.67 kB
dotcom-rendering/dist/EditionDropdown-importable.legacy.js	3.73 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.js	2.8 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.js	2.88 kB
dotcom-rendering/dist/embedIframe.js	1.74 kB
dotcom-rendering/dist/embedIframe.legacy.js	2.02 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.js	4.54 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.js	4.53 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.js	3.16 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.js	3.21 kB
dotcom-rendering/dist/FocusStyles-importable.js	4.69 kB
dotcom-rendering/dist/FocusStyles-importable.legacy.js	4.75 kB
dotcom-rendering/dist/ga.js	3.74 kB
dotcom-rendering/dist/ga.legacy.js	4.01 kB
dotcom-rendering/dist/GetMatchNav-importable.js	4.89 kB
dotcom-rendering/dist/GetMatchNav-importable.legacy.js	4.99 kB
dotcom-rendering/dist/GetMatchStats-importable.js	8.96 kB
dotcom-rendering/dist/GetMatchStats-importable.legacy.js	9.23 kB
dotcom-rendering/dist/GetMatchTabs-importable.js	5.69 kB
dotcom-rendering/dist/GetMatchTabs-importable.legacy.js	5.88 kB
dotcom-rendering/dist/guardian-braze-components-banner.js	11.3 kB
dotcom-rendering/dist/guardian-braze-components-banner.legacy.js	11.3 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.js	7.68 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.js	7.7 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.js	247 B
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.js	257 B
dotcom-rendering/dist/initDiscussion.js	8.9 kB
dotcom-rendering/dist/initDiscussion.legacy.js	9.18 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.js	2.94 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.js	3.02 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.js	6.56 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.js	6.83 kB
dotcom-rendering/dist/islands.js	9.06 kB
dotcom-rendering/dist/islands.legacy.js	9.82 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.js	252 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.js	263 B
dotcom-rendering/dist/LabsHeader-importable.js	8.26 kB
dotcom-rendering/dist/LabsHeader-importable.legacy.js	8.4 kB
dotcom-rendering/dist/Links-importable.js	6.15 kB
dotcom-rendering/dist/Links-importable.legacy.js	6.52 kB
dotcom-rendering/dist/LiveBlogEpic-importable.js	5 kB
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.js	3.16 kB
dotcom-rendering/dist/Liveness-importable.js	5.78 kB
dotcom-rendering/dist/Liveness-importable.legacy.js	5.91 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.js	7.62 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.js	7.9 kB
dotcom-rendering/dist/MostViewedFooterData-importable.js	11.7 kB
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.js	12 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.js	7 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.js	7.52 kB
dotcom-rendering/dist/newsletterEmbedIframe.js	1.9 kB
dotcom-rendering/dist/newsletterEmbedIframe.legacy.js	2.16 kB
dotcom-rendering/dist/OnwardsLower-importable.js	14.3 kB
dotcom-rendering/dist/OnwardsLower-importable.legacy.js	14.6 kB
dotcom-rendering/dist/OnwardsUpper-importable.js	16.8 kB
dotcom-rendering/dist/OnwardsUpper-importable.legacy.js	17.4 kB
dotcom-rendering/dist/ophan.js	7.04 kB
dotcom-rendering/dist/ophan.legacy.js	7.26 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.js	254 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.js	266 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.js	249 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.js	258 B
dotcom-rendering/dist/PulsingDot-importable.js	1.64 kB
dotcom-rendering/dist/PulsingDot-importable.legacy.js	1.74 kB
dotcom-rendering/dist/QandaAtomWrapper-importable.js	247 B
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.js	257 B
dotcom-rendering/dist/ReaderRevenueDev-importable.js	4.56 kB
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.js	4.58 kB
dotcom-rendering/dist/readerRevenueDevUtils.js	3.21 kB
dotcom-rendering/dist/readerRevenueDevUtils.legacy.js	4.08 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.js	5 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.js	5.4 kB
dotcom-rendering/dist/relativeTime.js	2.28 kB
dotcom-rendering/dist/relativeTime.legacy.js	2.56 kB
dotcom-rendering/dist/RichLinkComponent-importable.js	8.31 kB
dotcom-rendering/dist/RichLinkComponent-importable.legacy.js	8.51 kB
dotcom-rendering/dist/sentry.js	666 B
dotcom-rendering/dist/sentry.legacy.js	673 B
dotcom-rendering/dist/sentryLoader.js	4.72 kB
dotcom-rendering/dist/sentryLoader.legacy.js	7.69 kB
dotcom-rendering/dist/ShareCount-importable.js	6.25 kB
dotcom-rendering/dist/ShareCount-importable.legacy.js	6.42 kB
dotcom-rendering/dist/shimport.js	2.76 kB
dotcom-rendering/dist/shimport.legacy.js	2.76 kB
dotcom-rendering/dist/SignInGateMain.js	4.47 kB
dotcom-rendering/dist/SignInGateMain.legacy.js	4.57 kB
dotcom-rendering/dist/SignInGateSelector-importable.js	5.26 kB
dotcom-rendering/dist/SignInGateSelector-importable.legacy.js	5.67 kB
dotcom-rendering/dist/SlotBodyEnd-importable.js	11.9 kB
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.js	13.1 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.js	7.54 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.js	7.81 kB
dotcom-rendering/dist/StickyBottomBanner-importable.js	10.1 kB
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.js	12 kB
dotcom-rendering/dist/StickyVideo-importable.js	5.62 kB
dotcom-rendering/dist/StickyVideo-importable.legacy.js	5.77 kB
dotcom-rendering/dist/SubNav-importable.js	5.87 kB
dotcom-rendering/dist/SubNav-importable.legacy.js	6.06 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.js	249 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.js	259 B
dotcom-rendering/dist/TopRightAdSlot-importable.js	2.03 kB
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.js	2.36 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.js	2.92 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.js	3.01 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.js	7.64 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.js	7.9 kB
dotcom-rendering/dist/VineBlockComponent-importable.js	2.75 kB
dotcom-rendering/dist/VineBlockComponent-importable.legacy.js	2.83 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.js	6.27 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.js	6.63 kB

_{compressed-size-action}

[AshCorr]

Cool stuff!