This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Refactor expansion #559
Merged
Refactor expansion #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -40 B (0%) Total Size: 218 kB
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR simplifies how expansion is handled.
It removes the callback we were using to track how long it took to expand as this were adding complexity to the code and was no longer needed or used. We previously used this callback as part of the migration to Emotion 11 work.
It adds a step to ensure that the
isExpandedstate is set whenever theexpandedprop changes. There are use cases where theDiscussioncomponent in the parent is reloaded with a new value for this prop (permalinks) and we need to respect this.This PR closes guardian/dotcom-rendering#4297