Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment permalinks not working #4297

Closed
VDuczekW opened this issue Mar 17, 2022 · 3 comments · Fixed by guardian/discussion-rendering#559
Closed

Comment permalinks not working #4297

VDuczekW opened this issue Mar 17, 2022 · 3 comments · Fixed by guardian/discussion-rendering#559
Assignees

Comments

@VDuczekW
Copy link

Navigate to a profile's comments section page e.g. indigenousbrit's public profile | Identity | The Guardian
Try to navigate to one of the 'view discussion' links e.g. The 20 best recipes for the weekend

The article loads correctly, but does not scroll down to the user's comment.

I wonder if this may be to do with the fact that discussion-rendering is lazy-loaded?

@VDuczekW
Copy link
Author

is this still needed - was converting Trello https://trello.com/c/HCtFozEA/464-move-to-github-comment-permalinks-not-working but can see this PR attached which is merged #3873
@oliverlloyd & @mxdvl

@VDuczekW VDuczekW added the Bug label Mar 17, 2022
@oliverlloyd
Copy link
Contributor

That other PR partially fixed this issue but comment permalinks are still broken, sadly 😞

@VDuczekW
Copy link
Author

@mxdvl & @bryophyta please check and see if this can be linked or closed due to a dupe ticket existing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants