Use local copy of article format types in DCR #12461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
changed the title
@guardian/libs
|
Size Change: -23.3 kB (-2.54%) Total Size: 897 kB
ℹ️ View Unchanged
|
jamesmockett
force-pushed
the
jm/move-article-format-dcar
branch
from
d7db13a to
e709576
Compare
jamesmockett
force-pushed
the
jm/move-article-format-dcar
branch
from
e709576 to
236a2ef
Compare
jamesmockett
changed the title
jamesmockett
force-pushed
the
jm/move-article-format-dcar
branch
3 times, most recently
from
d9eb7e4 to
ddf047f
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
force-pushed
the
jm/move-article-format-dcar
branch
from
66101ce to
9790f09
Compare
This was referenced Oct 9, 2024
JamieB-gu
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Why has this schema file changed?
There was a problem hiding this comment.
I'm not entirely sure to be honest! After I finished updating the imports it said the schema no longer matched and I should run make gen-schema to update. It looks like it has been reordered rather than anything being added or removed though. Could it be because of the import order changing? I've tried reverting the changes to match what's currently in main, but it failed schema validation again.
There was a problem hiding this comment.
Why has this schema file changed?
SiAdcock
added a commit
to guardian/csnx
that referenced
this pull request
Oct 10, 2024
## What are you changing? - Remove the EditorialButton and EditorialLinkButton component, related tests and stories ## Why? - EditorialButton has only ever been used in [one place in DCR](https://github.com/guardian/dotcom-rendering/blob/4f75a0dbaf5a5dd756b1e8a1bb0aafa542e398a3/dotcom-rendering/src/components/Toast.tsx#L5). - We are moving format-related types into DCR (guardian/dotcom-rendering#12461). Removing this component removes one usage of format outside of DCR
SiAdcock
added a commit
to guardian/csnx
that referenced
this pull request
Oct 10, 2024
## What are you changing? - Remove the QuoteIcon component, related tests and stories, and the HeadlineSize type - Extra bit: Fix the Logo README title, which was previously mistakenly "QuoteIcon" ## Why? - QuoteIcon and HeadlineSize are not used anywhere. DCR uses [its own implementation](https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/QuoteIcon.tsx) - We are moving format-related types into DCR (guardian/dotcom-rendering#12461). Removing this component removes one usage of format outside of DCR
JamieB-gu
approved these changes
Oct 10, 2024
|
Seen on PROD (created by @jamesmockett and merged by @SiAdcock 8 minutes and 30 seconds ago) Please check your changes! |
rebecca-thompson
added a commit
that referenced
this pull request
Oct 28, 2024
simonbyford
pushed a commit
that referenced
this pull request
Nov 21, 2024
simonbyford
pushed a commit
that referenced
this pull request
Dec 3, 2024
simonbyford
pushed a commit
that referenced
this pull request
Dec 11, 2024
simonbyford
pushed a commit
that referenced
this pull request
Dec 11, 2024
simonbyford
pushed a commit
that referenced
this pull request
Dec 16, 2024
simonbyford
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
@guardian/libs:ArticleDesignArticleDisplayArticleSpecialArticleThemeArticleFormatPillarWhy?
A small number of Source Development Kitchen components expose a
formatprop which is typed asArticleFormat. Due to the need for these types to be used by Source and DCR they currently live in@guardian/libs, although DCR is the main consumer. We want to decouple this dependency by refactoring the Source components to replace theformatprop with a more generic theming mechanism, not tied to article formats, and move the types from@guardian/libsto the DCR codebase where they can be more easily updated.This is part of a larger piece of work to remove
PrintShopfromArticleDesign.