Inline EditorialButton and EditorialLinkButton into DCR #12520

SiAdcock · 2024-10-09T10:46:53Z

What does this change?

Inlines the EditorialButton and EditorialLinkButton components into DCR

Why?

These components are part of @guardian/source-development-kitchen, but have only been used in one place in 2 years.

As editorial components, it only makes sense to use these buttons in an editorial context, for which DCR is becoming the single source of rendering truth.

I'm making this change in the context of the extraction of format-related types from the shared @guardian/libs package into DCR. See also #12461

github-actions · 2024-10-09T10:47:08Z

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

github-actions · 2024-10-09T10:51:35Z

Size Change: +73 B (+0.01%)

Total Size: 898 kB

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/1000.client.web.********************.js`	999 B	0 B
`dotcom-rendering/dist/1026.client.web.********************.js`	784 B	0 B
`dotcom-rendering/dist/1090.client.web.********************.js`	752 B	0 B
`dotcom-rendering/dist/1156.client.web.********************.js`	3.95 kB	0 B
`dotcom-rendering/dist/1391.client.web.********************.js`	725 B	0 B
`dotcom-rendering/dist/1417.client.web.********************.js`	2.28 kB	0 B
`dotcom-rendering/dist/1476.client.web.********************.js`	784 B	0 B
`dotcom-rendering/dist/1667.client.web.********************.js`	918 B	0 B
`dotcom-rendering/dist/1884.client.web.********************.js`	3.4 kB	0 B
`dotcom-rendering/dist/1888.client.web.********************.js`	2.92 kB	0 B
`dotcom-rendering/dist/1904.client.web.********************.js`	12.6 kB	0 B
`dotcom-rendering/dist/1940.client.web.********************.js`	507 B	0 B
`dotcom-rendering/dist/2123.client.web.********************.js`	619 B	0 B
`dotcom-rendering/dist/2182.client.web.********************.js`	529 B	0 B
`dotcom-rendering/dist/2249.client.web.********************.js`	4.91 kB	0 B
`dotcom-rendering/dist/2310.client.web.********************.js`	880 B	0 B
`dotcom-rendering/dist/2390.client.web.********************.js`	4.06 kB	0 B
`dotcom-rendering/dist/267.client.web.********************.js`	917 B	0 B
`dotcom-rendering/dist/281.client.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/3006.client.web.********************.js`	4.49 kB	0 B
`dotcom-rendering/dist/3109.client.web.********************.js`	803 B	0 B
`dotcom-rendering/dist/3270.client.web.********************.js`	961 B	0 B
`dotcom-rendering/dist/3304.client.web.********************.js`	853 B	0 B
`dotcom-rendering/dist/3673.client.web.********************.js`	3.16 kB	0 B
`dotcom-rendering/dist/3769.client.web.********************.js`	999 B	0 B
`dotcom-rendering/dist/408.client.web.********************.js`	10.6 kB	0 B
`dotcom-rendering/dist/4088.client.web.********************.js`	3.97 kB	0 B
`dotcom-rendering/dist/4122.client.web.********************.js`	1.83 kB	0 B
`dotcom-rendering/dist/4149.client.web.********************.js`	3.77 kB	0 B
`dotcom-rendering/dist/4172.client.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/4282.client.web.********************.js`	685 B	0 B
`dotcom-rendering/dist/4367.client.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/4493.client.web.********************.js`	4.4 kB	0 B
`dotcom-rendering/dist/4501.client.web.********************.js`	4.29 kB	0 B
`dotcom-rendering/dist/4590.client.web.********************.js`	5.29 kB	0 B
`dotcom-rendering/dist/4628.client.web.********************.js`	654 B	0 B
`dotcom-rendering/dist/4696.client.web.********************.js`	3.67 kB	0 B
`dotcom-rendering/dist/4749.client.web.********************.js`	20.2 kB	0 B
`dotcom-rendering/dist/4799.client.web.********************.js`	4.02 kB	0 B
`dotcom-rendering/dist/4866.client.web.********************.js`	6.31 kB	0 B
`dotcom-rendering/dist/4875.client.web.********************.js`	157 B	0 B
`dotcom-rendering/dist/4886.client.web.********************.js`	8.09 kB	0 B
`dotcom-rendering/dist/4941.client.web.********************.js`	890 B	0 B
`dotcom-rendering/dist/4966.client.web.********************.js`	6.18 kB	0 B
`dotcom-rendering/dist/5087.client.web.********************.js`	439 B	0 B
`dotcom-rendering/dist/5340.client.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/5341.client.web.********************.js`	2.17 kB	0 B
`dotcom-rendering/dist/5371.client.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/5409.client.web.********************.js`	3.03 kB	0 B
`dotcom-rendering/dist/5658.client.web.********************.js`	750 B	0 B
`dotcom-rendering/dist/5757.client.web.********************.js`	931 B	0 B
`dotcom-rendering/dist/5761.client.web.********************.js`	4.65 kB	0 B
`dotcom-rendering/dist/5870.client.web.********************.js`	5.2 kB	0 B
`dotcom-rendering/dist/5880.client.web.********************.js`	828 B	0 B
`dotcom-rendering/dist/5944.client.web.********************.js`	4.97 kB	0 B
`dotcom-rendering/dist/5982.client.web.********************.js`	3.78 kB	0 B
`dotcom-rendering/dist/6044.client.web.********************.js`	726 B	0 B
`dotcom-rendering/dist/6058.client.web.********************.js`	3.24 kB	0 B
`dotcom-rendering/dist/6071.client.web.********************.js`	577 B	0 B
`dotcom-rendering/dist/6135.client.web.********************.js`	779 B	0 B
`dotcom-rendering/dist/6505.client.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/6565.client.web.********************.js`	1.99 kB	0 B
`dotcom-rendering/dist/6598.client.web.********************.js`	780 B	0 B
`dotcom-rendering/dist/661.client.web.********************.js`	3.21 kB	0 B
`dotcom-rendering/dist/6638.client.web.********************.js`	907 B	0 B
`dotcom-rendering/dist/6738.client.web.********************.js`	6.46 kB	0 B
`dotcom-rendering/dist/678.client.web.********************.js`	804 B	0 B
`dotcom-rendering/dist/6915.client.web.********************.js`	22.7 kB	0 B
`dotcom-rendering/dist/7072.client.web.********************.js`	3.85 kB	0 B
`dotcom-rendering/dist/7116.client.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7242.client.web.********************.js`	4.55 kB	0 B
`dotcom-rendering/dist/7341.client.web.********************.js`	4 kB	0 B
`dotcom-rendering/dist/7352.client.web.********************.js`	5.91 kB	0 B
`dotcom-rendering/dist/7407.client.web.********************.js`	3.71 kB	0 B
`dotcom-rendering/dist/7691.client.web.********************.js`	853 B	0 B
`dotcom-rendering/dist/7722.client.web.********************.js`	2.17 kB	0 B
`dotcom-rendering/dist/7780.client.web.********************.js`	2.27 kB	0 B
`dotcom-rendering/dist/7962.client.web.********************.js`	3.58 kB	0 B
`dotcom-rendering/dist/823.client.web.********************.js`	16.4 kB	0 B
`dotcom-rendering/dist/827.client.web.********************.js`	3.89 kB	0 B
`dotcom-rendering/dist/83.client.web.********************.js`	750 B	0 B
`dotcom-rendering/dist/840.client.web.********************.js`	3.2 kB	0 B
`dotcom-rendering/dist/8476.client.web.********************.js`	2.42 kB	0 B
`dotcom-rendering/dist/8483.client.web.********************.js`	13.9 kB	0 B
`dotcom-rendering/dist/8504.client.web.********************.js`	827 B	0 B
`dotcom-rendering/dist/8536.client.web.********************.js`	595 B	0 B
`dotcom-rendering/dist/8626.client.web.********************.js`	890 B	0 B
`dotcom-rendering/dist/8648.client.web.********************.js`	2.87 kB	0 B
`dotcom-rendering/dist/8667.client.web.********************.js`	4.26 kB	0 B
`dotcom-rendering/dist/8697.client.web.********************.js`	956 B	0 B
`dotcom-rendering/dist/8730.client.web.********************.js`	4.43 kB	0 B
`dotcom-rendering/dist/8746.client.web.********************.js`	3.01 kB	0 B
`dotcom-rendering/dist/8822.client.web.********************.js`	526 B	0 B
`dotcom-rendering/dist/8833.client.web.********************.js`	829 B	0 B
`dotcom-rendering/dist/8990.client.web.********************.js`	3.41 kB	0 B
`dotcom-rendering/dist/9054.client.web.********************.js`	1.91 kB	0 B
`dotcom-rendering/dist/9105.client.web.********************.js`	2.02 kB	0 B
`dotcom-rendering/dist/9132.client.web.********************.js`	4.2 kB	0 B
`dotcom-rendering/dist/9184.client.web.********************.js`	493 B	0 B
`dotcom-rendering/dist/9216.client.web.********************.js`	3.45 kB	0 B
`dotcom-rendering/dist/940.client.web.********************.js`	10.2 kB	0 B
`dotcom-rendering/dist/9493.client.web.********************.js`	785 B	0 B
`dotcom-rendering/dist/9557.client.web.********************.js`	921 B	0 B
`dotcom-rendering/dist/9721.client.web.********************.js`	717 B	0 B
`dotcom-rendering/dist/9736.client.web.********************.js`	44.2 kB	0 B
`dotcom-rendering/dist/9835.client.web.********************.js`	647 B	0 B
`dotcom-rendering/dist/9899.client.web.********************.js`	669 B	0 B
`dotcom-rendering/dist/Accessibility-importable.client.web.********************.js`	5.96 kB	0 B
`dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.client.web.********************.js`	3.94 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js`	424 B	0 B
`dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js`	3.57 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js`	3.16 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js`	3.15 kB	0 B
`dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js`	2.5 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js`	4.88 kB	0 B
`dotcom-rendering/dist/Branding-importable.client.web.********************.js`	2.54 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js`	37.2 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js`	1.96 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js`	6.71 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js`	7.92 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js`	2.97 kB	0 B
`dotcom-rendering/dist/Carousel-importable.client.web.********************.js`	6.69 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js`	4.52 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js`	539 B	0 B
`dotcom-rendering/dist/CommentCount-importable.client.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js`	1.91 kB	0 B
`dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js`	1.22 kB	0 B
`dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js`	1.74 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js`	3.14 kB	0 B
`dotcom-rendering/dist/Dropdown-importable.client.web.********************.js`	1.72 kB	0 B
`dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js`	5.97 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js`	3.77 kB	0 B
`dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js`	2.01 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js`	2.41 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js`	968 B	0 B
`dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js`	619 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js`	3.43 kB	0 B
`dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js`	347 B	0 B
`dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js`	3.74 kB	0 B
`dotcom-rendering/dist/frameworks.client.web.********************.js`	20.9 kB	0 B
`dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js`	7.65 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js`	3.82 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js`	10.6 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js`	7.42 kB	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js`	2.22 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js`	15.9 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js`	10.1 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/index.client.web.********************.js`	45 kB	+3 B (+0.01%)
`dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js`	849 B	0 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js`	6.28 kB	0 B
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js`	4.24 kB	0 B
`dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js`	4.77 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js`	3.61 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js`	4.18 kB	0 B
`dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js`	436 B	0 B
`dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js`	6.51 kB	0 B
`dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js`	3.78 kB	0 B
`dotcom-rendering/dist/LiveblogNotifications-importable.client.web.********************.js`	5.27 kB	0 B
`dotcom-rendering/dist/Liveness-importable.client.web.********************.js`	5.52 kB	+70 B (+1.28%)
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js`	7.63 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js`	4.95 kB	0 B
`dotcom-rendering/dist/Metrics-importable.client.web.********************.js`	2.69 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js`	4 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js`	6.71 kB	0 B
`dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js`	5.68 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js`	5.8 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js`	3.77 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js`	543 B	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js`	803 B	0 B
`dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js`	750 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js`	542 B	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js`	469 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js`	1.97 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js`	2.53 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js`	6.78 kB	0 B
`dotcom-rendering/dist/ScrollableHighlights-importable.client.web.********************.js`	5 kB	0 B
`dotcom-rendering/dist/ScrollableSmall-importable.client.web.********************.js`	2.95 kB	0 B
`dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js`	4.6 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js`	2.19 kB	0 B
`dotcom-rendering/dist/sentry.client.web.********************.js`	792 B	0 B
`dotcom-rendering/dist/SetABTests-importable.client.web.********************.js`	3.69 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js`	484 B	0 B
`dotcom-rendering/dist/ShareButton-importable.client.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/shimport.client.web.********************.js`	2.8 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js`	729 B	0 B
`dotcom-rendering/dist/ShowMore-importable.client.web.********************.js`	1.75 kB	0 B
`dotcom-rendering/dist/SignInGateMain.client.web.********************.js`	4.53 kB	0 B
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js`	5.63 kB	0 B
`dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js`	3.16 kB	0 B
`dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js`	3.49 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js`	4.8 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js`	4.21 kB	0 B
`dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js`	7.68 kB	0 B
`dotcom-rendering/dist/SubNav-importable.client.web.********************.js`	2.9 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js`	2.7 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js`	1.23 kB	0 B
`dotcom-rendering/dist/Titlepiece-importable.client.web.********************.js`	14.7 kB	0 B
`dotcom-rendering/dist/TopBar-importable.client.web.********************.js`	8.26 kB	0 B
`dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js`	2.75 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js`	1.13 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js`	2.8 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js`	4.96 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js`	2.63 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js`	6.55 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js`	5.94 kB	0 B

_{compressed-size-action}

github-actions · 2024-10-09T10:53:23Z

Deploy build 37978 of `Mobile::mobile-apps-rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2024-10-09T10:56:27Z

Deploy build 13809 of `dotcom:rendering-all` to CODE

All deployment options

From guardian/actions-riff-raff.

JamieB-gu

Looks good! A few questions/suggestions.

dotcom-rendering/src/components/EditorialButton/EditorialButton.stories.tsx

dotcom-rendering/src/components/EditorialButton/EditorialButton.tsx

dotcom-rendering/src/components/EditorialButton/EditorialLinkButton.stories.tsx

dotcom-rendering/src/components/EditorialButton/EditorialLinkButton.tsx

dotcom-rendering/src/components/EditorialButton/styles.ts

JamieB-gu · 2024-10-09T12:27:35Z

dotcom-rendering/src/components/EditorialButton/styles.ts

Probably one for a follow-up, but most of this file can probably be integrated into DCAR's palette?

dotcom-rendering/src/components/EditorialButton/types.ts

Co-authored-by: Jamie B <[email protected]>

prout-bot · 2024-10-11T12:12:18Z

Seen on PROD (merged by @SiAdcock 8 minutes and 46 seconds ago) Please check your changes!

SiAdcock requested a review from a team as a code owner October 9, 2024 10:46

SiAdcock changed the title ~~Inline editorial button into DCR~~ Inline EditorialButton into DCR Oct 9, 2024

github-actions bot added the dotcom-rendering label Oct 9, 2024

SiAdcock mentioned this pull request Oct 9, 2024

Decouple Source dev kitchen components from ArticleFormat #12493

Closed

SiAdcock force-pushed the sa-inline-editorial-button branch from 5074740 to bb27ca0 Compare October 9, 2024 10:51

SiAdcock added the run_chromatic Runs chromatic when label is applied label Oct 9, 2024

SiAdcock changed the title ~~Inline EditorialButton into DCR~~ Inline EditorialButton and EditorialLinkButton into DCR Oct 9, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 9, 2024

JamieB-gu reviewed Oct 9, 2024

View reviewed changes

SiAdcock added the run_chromatic Runs chromatic when label is applied label Oct 10, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 10, 2024

SiAdcock requested a review from JamieB-gu October 10, 2024 14:28

SiAdcock and others added 3 commits October 11, 2024 11:54

inline editorial button into dcr

c20cfb3

Apply suggestions from code review

5ba77ae

Co-authored-by: Jamie B <[email protected]>

use DCR version of format types

d4970f0

SiAdcock force-pushed the sa-inline-editorial-button branch from 1458a82 to d4970f0 Compare October 11, 2024 11:47

SiAdcock added the run_chromatic Runs chromatic when label is applied label Oct 11, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 11, 2024

JamieB-gu approved these changes Oct 11, 2024

View reviewed changes

SiAdcock merged commit 0dfd1ca into main Oct 11, 2024
32 checks passed

SiAdcock deleted the sa-inline-editorial-button branch October 11, 2024 12:03

prout-bot added Pending-on-PROD Seen-on-PROD and removed Pending-on-PROD labels Oct 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inline EditorialButton and EditorialLinkButton into DCR #12520

Inline EditorialButton and EditorialLinkButton into DCR #12520

SiAdcock commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

JamieB-gu left a comment

JamieB-gu Oct 9, 2024

prout-bot commented Oct 11, 2024

Inline EditorialButton and EditorialLinkButton into DCR #12520

Inline EditorialButton and EditorialLinkButton into DCR #12520

Conversation

SiAdcock commented Oct 9, 2024 • edited Loading

What does this change?

Why?

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024 • edited Loading

github-actions bot commented Oct 9, 2024 • edited Loading

Deploy build 37978 of Mobile::mobile-apps-rendering to CODE

github-actions bot commented Oct 9, 2024 • edited Loading

Deploy build 13809 of dotcom:rendering-all to CODE

JamieB-gu left a comment

Choose a reason for hiding this comment

JamieB-gu Oct 9, 2024

Choose a reason for hiding this comment

prout-bot commented Oct 11, 2024

SiAdcock commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

Deploy build 37978 of `Mobile::mobile-apps-rendering` to CODE

github-actions bot commented Oct 9, 2024 •

edited

Loading

Deploy build 13809 of `dotcom:rendering-all` to CODE