Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local copy of article format types in AR #12495

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

jamesmockett
Copy link
Contributor

What does this change?

  • Adds local copy of article format types from @guardian/libs:
    • ArticleDesign
    • ArticleDisplay
    • ArticleSpecial
    • ArticleTheme
    • ArticleFormat
    • Pillar
  • Updates existing imports to point to local version

This is a companion to #12461 which applies the same changes to DCR.

Why?

A small number of Source Development Kitchen components expose a format prop which is typed as ArticleFormat. Due to the need for these types to be used by Source and DCR they currently live in @guardian/libs, although DCR is the main consumer. We want to decouple this dependency by refactoring the Source components to replace the format prop with a more generic theming mechanism, not tied to article formats, and move the types from @guardian/libs to the DCR codebase where they can be more easily updated.

This is part of a larger piece of work to remove PrintShop from ArticleDesign.

@jamesmockett jamesmockett self-assigned this Oct 3, 2024
@jamesmockett jamesmockett added this to the Health milestone Oct 3, 2024
@jamesmockett jamesmockett linked an issue Oct 3, 2024 that may be closed by this pull request
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Oct 3, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 3, 2024
@jamesmockett jamesmockett force-pushed the jm/move-article-format-ar branch from 151d994 to c8858f9 Compare October 3, 2024 13:27
@jamesmockett jamesmockett force-pushed the jm/move-article-format-ar branch 2 times, most recently from ab818ed to 7467405 Compare October 7, 2024 13:15
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Oct 7, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 7, 2024
@jamesmockett jamesmockett force-pushed the jm/move-article-format-ar branch from 7467405 to d8a3163 Compare October 7, 2024 14:20
@jamesmockett jamesmockett marked this pull request as ready for review October 7, 2024 14:30
@jamesmockett jamesmockett requested a review from a team as a code owner October 7, 2024 14:30
Copy link

github-actions bot commented Oct 7, 2024

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@jamesmockett jamesmockett force-pushed the jm/move-article-format-ar branch from d8a3163 to 5e3266e Compare October 8, 2024 09:37
@SiAdcock SiAdcock added the run_chromatic Runs chromatic when label is applied label Oct 9, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 9, 2024
@SiAdcock SiAdcock merged commit 9c31292 into main Oct 11, 2024
32 checks passed
@SiAdcock SiAdcock deleted the jm/move-article-format-ar branch October 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ArticleFormat types into AR
3 participants