-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example 5bus case, contingency screening capability, and #128
Conversation
This reverts commit b7d9eb3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The static variable thing I commented on doesn't need to be addressed.
def _ensure_contingencies_monitored(options:Options, md:EgretModel, initial_day:bool = False) -> None: | ||
''' Add contingency screening, if that option is enabled ''' | ||
if initial_day: | ||
_ensure_contingencies_monitored.contingency_dicts = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of this function-local static variable makes the code not thread safe. For now that's OK, but at some point we might want to address it. create_sced_instance.shutdown_curves is another example of this.
Linked to Issue #130.
...set up penalties for advanced reserves. Switches Prescient to use new penalty cascade logic in Egret (grid-parity-exchange/Egret#259). Depends on grid-parity-exchange/Egret#259.