Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example 5bus case, contingency screening capability, and #128

Merged
merged 26 commits into from
Jan 12, 2022

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Jan 3, 2022

...set up penalties for advanced reserves. Switches Prescient to use new penalty cascade logic in Egret (grid-parity-exchange/Egret#259). Depends on grid-parity-exchange/Egret#259.

@bknueven bknueven linked an issue Jan 3, 2022 that may be closed by this pull request
@bknueven bknueven marked this pull request as ready for review January 10, 2022 22:22
Copy link
Collaborator

@darrylmelander darrylmelander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The static variable thing I commented on doesn't need to be addressed.

def _ensure_contingencies_monitored(options:Options, md:EgretModel, initial_day:bool = False) -> None:
''' Add contingency screening, if that option is enabled '''
if initial_day:
_ensure_contingencies_monitored.contingency_dicts = {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of this function-local static variable makes the code not thread safe. For now that's OK, but at some point we might want to address it. create_sced_instance.shutdown_curves is another example of this.

Linked to Issue #130.

@bknueven bknueven enabled auto-merge (squash) January 12, 2022 00:20
@bknueven bknueven merged commit 8fef0fa into grid-parity-exchange:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add working minimum working example
2 participants