one penalty to rule them all #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpaulwatson
approved these changes
Dec 15, 2021
| ## set these penalties in relation to each other, from higher quality service to lower | ||
| model.RegulationPenalty = Param(within=NonNegativeReals, | ||
| initialize=system.get('regulation_penalty_price', default_reg_pen), | ||
| rule=make_penalty_rule(model, 'regulation_penalty_price', 4.), |
There was a problem hiding this comment.
General comment: these are sufficiently important constants that I think they warrant a big comment block in the corresponding files, defining the values and the hierarchy/presence.
| @@ -194,28 +194,26 @@ def load_params(model, model_data, slack_type): | |||
| # penalty costs for constraint violation # | |||
| ########################################## | |||
|
|
|||
There was a problem hiding this comment.
General comment: these are sufficiently important constants that I think they warrant a big comment block in the corresponding files, defining the values and the hierarchy/presence.
|
@jeanpaulwatson I added comment blocks in both params.py and services.py, which hopefully make the intention clear. |
bknueven
added a commit
to grid-parity-exchange/Prescient
that referenced
this pull request
Jan 12, 2022
* initial pass at 5bus example * allowing default forecastables * relaxing line limits * adding runner script * correcting issue with REAL_TIME period resolution * Revert "relaxing line limits" This reverts commit b7d9eb3. * updating network and adding generator * ensure reserve factor is honored even if not pre-existing * first pass at enabling contingency monitoring * considering more flexible thermal units * adding contingency reporting * updating price thresholds * switching penalty logic to use grid-parity-exchange/Egret#259 * NFC: removing finished TODO * fixing names * adding python simulator script * more reasonable mipgap * removing violation, for now * Fix spelling, update variable name Co-authored-by: Darryl Melander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: