-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional requirement and simple test case for Prescient #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested option changes below should get you a much faster test.
@bknueven thanks for the updated options! The runtime is ~10-15 s on the GHA runners, which I think is just fine for a component test. Do you have any suggestion for a basic validation of the results once the simulation is complete? The current implementation just asserts that at least two files have been created in the output directory, which is not a particularly stringent check... |
Prescient's own regression tests are available here: https://github.com/grid-parity-exchange/Prescient/blob/main/tests/simulator_tests/test_sim_rts_mod.py That said, something simpler might just be to check for the existence of If you want to check the values in any of the files, you should update the |
1044dd8
to
131827a
Compare
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 67.23% 67.23%
=======================================
Files 528 528
Lines 60358 60358
Branches 11095 11095
=======================================
+ Hits 40579 40582 +3
- Misses 17692 17693 +1
+ Partials 2087 2083 -4
Continue to review full report at Codecov.
|
@bknueven Is there a planned timeline for when a new version of Prescient including these changes will be released on PyPI? From the IDAES side, I think this is ready to go, but I imagine it would be preferable to use a PyPI release (rather than |
We could cut the Prescient release when convenient. We were hoping to get one more feature in, but we also don't want to hold up the IDAES release or have IDAES released against a specific Prescient commit. |
@bknueven Thanks for the update. My question for purely for keeping track of this PR's status: personally I don't know how urgent it would be to have this merged into IDAES (and therefore how urgently we'd need to have the Prescient PyPI release). @adowling2, do you have any thoughts on the required or desired timeline for enabling Prescient in IDAES? |
Does not matter for this PR, but grid-parity-exchange/Prescient#139 distributes the Prescient regression test harness for doing regression tests of Prescient output. Perhaps useful for #638. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me
Co-authored-by: bknueven <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #467
Summary/Motivation:
Changes proposed in this PR:
gridx-prescient
as an optional dependency insetup.py
TODO before undrafting
setup.py
once Add example 5bus case, contingency screening capability, and grid-parity-exchange/Prescient#128 is merged intest_prescient.py
(or update marker topytest.mark.integration
)Reviewers
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: