-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prescient as an optional dependecy, support tests with Prescient #467
Comments
@lbianchi-lbl, will work on the infrastructure (dependencies, testing) parts. |
@xiangao1 Can you add a link to the Prescient example notebook? |
Here is the Prescient example notebook: https://github.com/grid-parity-exchange/Prescient/blob/main/examples/prescient_tutorial.ipynb |
From @bknueven, working on closing one open Prescient PR, then cut a PyPi release |
@lbianchi-lbl What are your thoughts on converting the above-linked notebook into a Prescient "existence" test? I think the test would essentially:
|
@adowling2 from what I can see from having skimmed through the notebook, I think this could be a reasonable option. A couple of questions:
|
Hi @lbianchi-lbl and @adowling2 , I learned that @bknueven has been working on this 5-bus example of Prescient, i.e., small scale, and it comes with the data: https://github.com/bknueven/Prescient/tree/5bus_case/examples Maybe this is what we need. |
Yes, this is actually what we want for an "existence" test. |
@xiangao1 Thanks for the pointer. At the link you posted, I can see some data files ( |
Ignore the notebook -- it needs to be updated. I'll add a Python file to the PR I'm already working on with that test case. |
Here is a good example runner file: https://github.com/bknueven/Prescient/blob/5bus_case/examples/simulate_5bus.py That takes about five minutes on my system. For the purposes of this test, we can change a few options to lower that time to 15 seconds. |
@bknueven that's awesome, thanks! I'll open a draft PR in IDAES using that code and data files. I understand that it might not work immediately, but at least we'll have a starting point to work on. |
The IDAES market integration feature #432 will include at least one regression test that involves Prescient. We should:
@xiangao1 @ksbeattie @lbianchi-lbl
The text was updated successfully, but these errors were encountered: