Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing __getitem__() with at() for ordered sets #243

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Replacing __getitem__() with at() for ordered sets #243

merged 6 commits into from
Aug 23, 2021

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Aug 18, 2021 •
edited
Loading

Fixes # N/A

Summary/Motivation:

Pyomo 6.1 deprecated __getitem__() for ordered Pyomo Sets

Changes proposed in this PR:

  • Replace all instances of __getitem__ with at for ordered Pyomo Sets.
  • Bump minimum Pyomo version to 6.1.2.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven mentioned this pull request Aug 18, 2021
Merged
@bknueven bknueven marked this pull request as draft August 20, 2021 18:08
@bknueven
Copy link
Collaborator Author

I'll update this for Pyomo 6.1.2, which moves card to at (Pyomo/pyomo#2096).

@bknueven bknueven changed the title Replacing __getitem__() with card() for ordered sets Replacing __getitem__() with at() for ordered sets Aug 20, 2021
@bknueven bknueven marked this pull request as ready for review August 20, 2021 22:01
@michaelbynum michaelbynum merged commit c4e5a05 into grid-parity-exchange:main Aug 23, 2021
@bknueven bknueven deleted the set_getitem_fix branch August 23, 2021 13:54
@bknueven bknueven mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbynum michaelbynum michaelbynum approved these changes

@jeanpaulwatson jeanpaulwatson Awaiting requested review from jeanpaulwatson

@carldlaird carldlaird Awaiting requested review from carldlaird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @michaelbynum