Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Set.card() with Set.at() #2096

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Replace Set.card() with Set.at() #2096

merged 1 commit into from
Aug 20, 2021

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Aug 19, 2021

Fixes # .

Summary/Motivation:

@eslickj correctly pointed out that card() was NOT the correct replacement for Set.__getitem__ (retrieving an item from an ordered Set by position). This PR corrects the mistake from #2053 and switches card() to at().

Changes proposed in this PR:

  • Replace Set.card() with Set.at()

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2096 (77717b8) into main (828c551) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2096   +/-   ##
=======================================
  Coverage   82.87%   82.88%           
=======================================
  Files         619      619           
  Lines       76848    76851    +3     
=======================================
+ Hits        63689    63696    +7     
+ Misses      13159    13155    -4     
Impacted Files Coverage Δ
pyomo/core/base/set.py 99.67% <100.00%> (+<0.01%) ⬆️
pyomo/dae/contset.py 98.96% <100.00%> (ø)
pyomo/contrib/mindtpy/iterate.py 76.73% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828c551...77717b8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants