Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing __getitem__() with at() for ordered sets, Part II #244

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Replacing __getitem__() with at() for ordered sets, Part II #244

merged 1 commit into from
Aug 23, 2021

Conversation

bknueven
Copy link
Collaborator

Fixes N/A

Summary/Motivation:

#243 missed an instance of SetData.getitem()

Changes proposed in this PR:

  • Replace __getitem__ with at in egret/model_library/unit_commitment/param.py
  • Minor cleanup of these validators.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven requested a review from michaelbynum August 23, 2021 14:36
@bknueven bknueven merged commit 03ee1fa into grid-parity-exchange:main Aug 23, 2021
@bknueven bknueven deleted the pyomo_612 branch August 23, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbynum michaelbynum michaelbynum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @michaelbynum