Fixes the github security errors #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Closed
|
Rest LGTM |
|
I was thinking the same thing. It's not really a security problem so I refactored it to be "nicer" to read. But I think the new solution is also readable and gives us the advantage, that it can not be spoofed. And CodeQL doesn't complain :) @ArneTR please merge if this is ok. |
|
cool |
ArneTR
added a commit
that referenced
this pull request
Aug 4, 2023
* main: Ignore filesystem paths Bugfix: Phases ordering was wrong way round eco-ci will now post the energy reading in the PR conversation (#397) SCI metric (#412) Fixes the github security errors (#411) API does not block returning machines, but will now return if they are available or not Enables empty services in the usage_scenario (#409) wrong import jobs.py now appends date Fixes the error on mac on which /tmp is a symlink to /private/tmp (#410) Fixes the metric output file becoming corrupted (#393) Only available machines may be listed Index.js now can filter by repo and filename (#408) Python requirements are now freshly updated with every install Gunicorn container now on python3-slim (Debian) instead of Ubuntu 22.04
ArneTR
added a commit
that referenced
this pull request
Aug 8, 2023
* main: (42 commits) Added exception handling to client.py Fix and better display of SCI values in badged and dashboard Increased the waiting time for powermetrics to shut down Bugfix for non-string types replacement Docker prune is now the default for jobs.py Bump psycopg[binary] from 3.1.9 to 3.1.10 (#413) Bump fastapi from 0.100.1 to 0.101.0 (#414) Bump orjson from 3.9.2 to 3.9.3 (#415) Ignore filesystem paths Bugfix: Phases ordering was wrong way round eco-ci will now post the energy reading in the PR conversation (#397) SCI metric (#412) Fixes the github security errors (#411) API does not block returning machines, but will now return if they are available or not Enables empty services in the usage_scenario (#409) wrong import jobs.py now appends date Fixes the error on mac on which /tmp is a symlink to /private/tmp (#410) Fixes the metric output file becoming corrupted (#393) Only available machines may be listed ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.