Fixes the metric output file becoming corrupted #393
Conversation
| time.sleep(1) | ||
| count += 1 | ||
| if count >= 5: | ||
| raise RuntimeError('powermetrics is not stopping. Please kill with `kill -9 ...`.') |
There was a problem hiding this comment.
If it needs to be anyway killed with kill -9, why don't we do it?
This would then not only leave the output file corrupted, but also the state of the GMT, as you might have two instances of powermetrics running. correct?
There was a problem hiding this comment.
Has been stale for a week now. If you do not have any further input I would vouch for changing the code to be less manual and more automatic.
There was a problem hiding this comment.
I now remember why I did it like this. kill -9 needs to be called as root and I was hesitant to add another line to sudoers. No real reason why to be honest. Added it.
|
@ArneTR ready to merge IMHO |
|
LGTM. I will merge it in and report back. Since the error happens only transiently I cannot really check it on the spot. Will report if I notice furhter errors. |
* main: Ignore filesystem paths Bugfix: Phases ordering was wrong way round eco-ci will now post the energy reading in the PR conversation (#397) SCI metric (#412) Fixes the github security errors (#411) API does not block returning machines, but will now return if they are available or not Enables empty services in the usage_scenario (#409) wrong import jobs.py now appends date Fixes the error on mac on which /tmp is a symlink to /private/tmp (#410) Fixes the metric output file becoming corrupted (#393) Only available machines may be listed Index.js now can filter by repo and filename (#408) Python requirements are now freshly updated with every install Gunicorn container now on python3-slim (Debian) instead of Ubuntu 22.04
* main: (42 commits) Added exception handling to client.py Fix and better display of SCI values in badged and dashboard Increased the waiting time for powermetrics to shut down Bugfix for non-string types replacement Docker prune is now the default for jobs.py Bump psycopg[binary] from 3.1.9 to 3.1.10 (#413) Bump fastapi from 0.100.1 to 0.101.0 (#414) Bump orjson from 3.9.2 to 3.9.3 (#415) Ignore filesystem paths Bugfix: Phases ordering was wrong way round eco-ci will now post the energy reading in the PR conversation (#397) SCI metric (#412) Fixes the github security errors (#411) API does not block returning machines, but will now return if they are available or not Enables empty services in the usage_scenario (#409) wrong import jobs.py now appends date Fixes the error on mac on which /tmp is a symlink to /private/tmp (#410) Fixes the metric output file becoming corrupted (#393) Only available machines may be listed ...
No description provided.