Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landuse labels should appear at z14 #913

Closed
1ec5 opened this issue Aug 28, 2014 · 3 comments · Fixed by #941
Closed

landuse labels should appear at z14 #913

1ec5 opened this issue Aug 28, 2014 · 3 comments · Fixed by #941

Comments

@1ec5
Copy link

1ec5 commented Aug 28, 2014

As a followup to #351, landuse labels should appear at z14, not just at z15 and above. In the suburbs, named residential and retail developments are often essential for navigation. They stand in for the more formal neighborhood boundaries that you might see in urban areas. A retail development is at least as much of a destination as a park or golf course.

f0d0c9e removed catch-all labels from polygons, which removed the vast majority of labels in suburban areas such as Miami Township, Clermont County, Ohio. You can get a good sense of where the labels used to be from FOSM, though they’ve reduced the size of these labels to a nearly unreadable size. Residential and retail developments were mapped as named landuse areas, most of which were labeled using the catch-all rule. (Here’s another example from nearby Mason: OSM, FOSM.)
#352 restored labels on landuse areas, but only at z15 and above. Unfortunately, at z15, highway=residential labels kick in, almost always crowding out the landuse labels. Given how empty the map looks at z14, there is plenty of room for landuse labels. I’m not asking for all landuse areas to be labeled, only those with a way_area above 150,000, for instance, that would’ve been caught in the past.

@matthijsmelissen
Copy link
Collaborator

Agree, we can usel number of pixels to render large landuse areas earlier.

@dieterdreist
Copy link

Il giorno 28/ago/2014, alle ore 11:53, Minh Nguyễn [email protected] ha scritto:

landuse labels should appear at z14, not just at z15 and above. In the suburbs, named residential and retail developments are often essential for navigation. They stand in for the more formal neighborhood boundaries that you might see in urban areas. A retail development is at least as much of a destination as a park or golf course.

IMHO landuses aren't the right object to add a name to it (despite the currently widespread practice to do so, I'd consider that bad mapping because it will hinder detailing landuse), they're an attribute about the usage of an area. Better use place entities for developments or other settlement parts, eg place=neighbourhood

@1ec5
Copy link
Author

1ec5 commented Aug 28, 2014

These developments are orthogonal to the type of information that place=* captures. A subdivision may be large enough to include several neighborhoods (with enough residents to legally incorporate as a city) or small enough to be part of a neighborhood (potentially too small to label at z14). Due to the way these places are zoned, the borders of these developments correspond exactly to the edges of a landuse area.

In any event, named landuses are already labeled in this stylesheet (and included in Nominatim); this request is just to make the labels more accessible.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 12, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 21, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 22, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants