-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels for rendered landuse and leisure polygons #352
Conversation
With that last commit, the most common leisure/landuse tags (>10,000 TagInfo uses) will render labels and polygons. The exceptions are:
|
Just to share some views for consideration - As the text size of the playgrounds, parks etc has been enlarged to 11, should similar or more prominent features e.g. stadium follow suit, instead of remaining at 9, and begin to render at z14 if they satisfy a size criteria? Similarly, for the text size for buildings vs that for landuse (residential, commercial, etc), the latter often encloses a number of the former, and should not be given less prominent labels. Thanks! |
could the key "landcover" also be integrated? Currently this is " trees" (e.g. lc=trees or Having landuse in a rule set called landcover seems strange btw |
@hlaw: I'd like that. While not affected by this change, natural=water was often large enough to render at z14 under the catch-all. Likewise, larger fonts also should make us think about features that are too small to render at z15 (I'm seeing pond names that are now larger than their pond). @dieterdreist: landcover would be a difficult addition because it's not in the DB at the moment. We need to sort that out because there's several such requests. |
"Darkens the danger_area text color (was pink on pink)." - it may be necessary also for landuse=military |
@mrwojo Good job! |
Edit: I read it properly now. Good job. |
@javbw landuse=greenhouse_horticulture won't be rendered yet with this change. For now I was focusing on restoring labels for areas that had been rendered previously. |
@mrwojo this is a fantastic commit, exactly what I was hoping for. The grid of outputs was especially handy when reviewing it! Thank you. |
Add labels for rendered landuse and leisure polygons
This shows name labels for all rendered leisure/landuse polygons. That is:
Notes:
darken()
ed color of the polygon.The following image shows the various types of polygon/text renderings at z18. (This is not all the features with names.)