Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tourism=theme_park label is unreadable and lacks priority. #308

Closed
javbw opened this issue Jan 10, 2014 · 4 comments · Fixed by #941
Closed

Tourism=theme_park label is unreadable and lacks priority. #308

javbw opened this issue Jan 10, 2014 · 4 comments · Fixed by #941

Comments

@javbw
Copy link

javbw commented Jan 10, 2014

Edit: found that Big Thunder mountain was actually tagged as a mountain, so I repaired it, but the request for the is label update is still needed. JW

tokyo_disneyland

Edit: fixed the mountain tags, and removed the incorrect station names -

update

Can you read 東京ディズニーランド in there? (it's rendered now)

Theme_park uses tan/thin white stroke, and attraction similarly uses tan/thick white stroke (which is slightly more readable)

Usually theme_park is filled with attractions, so the label should be a different, vibrant color, and have priority over attraction (currently "Big Thunder Mountain" attraction label is rendered instead of Disneyland's label at zoom 13)

zoom13

Theme parks are a tourist magnet, and a regional, sometimes national landmark, and are usually spaced very far apart, and need to be recognizably different form attractions and train stations, so a vibrant color would be acceptable - Maybe a bright magenta / white stroke.

@dieterdreist
Copy link

2014/1/10 javbw [email protected]

Usually theme_park is filled with attractions, so the label should be a
different, vibrant color, and have priority over attraction (currently an
attraction name is rendered instead of Disneyland's name at zoom 14) Maybe
a bright magenta / white stroke.

the attraction proposal is fine ( http://wiki.osm.org/wiki/Key:attraction )
but unlike its suggestion I wouldn't add tourism=attraction to every theme
park attraction (maybe to the theme park as a whole if applies).

@javbw
Copy link
Author

javbw commented Jan 13, 2014

Considering we have tags for individual trees and fire hydrants in a theme park (and what color the cap on said fire hydrant is), tags for the paths, parade routes, and names for at the restaurants, tagging major attractions (rides) in a theme park with a "attraction" tag seems appropriate. Tagging a whole Theme Park with Theme park also seems appropriate. We just need to set their priority and render levels correctly - and differentiate their tags. Making theme park render as a different color (magenta is my suggestion) and have rendering priority / lower zoom level rendering over attraction would solve all of these issues. Theme parks are important travel destinations, and need to be prominently displayed and easily differentiated from other labels.

Tokyo Disneyland/sea is about the same size as the village I live in, and there is a lot more detail for the village beyond it's name.

@brycenesbitt
Copy link

Agreed. The tourism=theme_park name should be similar in prominence to a city name.
See way 299951753 for an example where the name simply is not visible.

@Rovastar
Copy link
Contributor

Yes they should be more noticeable but again based on way size, as they can be small theme parks and not the same as a city.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 12, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 21, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 22, 2014
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants