This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[v9] Backport Teleport Connect (1 of 5) #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add more tests to Teleterm
The way their `run` function works conflicts with the new implementation (it directly changes quickInputService's state), so we remove that in this commit to have less to deal with in upcoming commits.
This commit does not support actually choosing any suggestion yet, just showing them in the UI.
Our new code isn't going to show anything when there are no matches.
This required adding all those mocks to the tests so that the returned suggestions in some of the tests are not empty.
1. Pressing Esc while suggestions are shown should first close the suggestions and the second press should actually exit the input. 2. Picking a suggestion should close the autocomplete if we didn't append anything to the token (see comment for details). 3. Typing something in the command bar should always show the autocomplete in case there are suggestions to show. Also remove unused call to setInputValue.
mcbattirola
approved these changes
Apr 26, 2022
hatched
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-checks and the tests are green.
Backport for the following PRs:
Connectionspopover #651QuickInputand add empty state to pickers #677